Skip to content

Conversation

@rjharishabh
Copy link
Contributor

Pull Request for Issue #.

Summary of Changes

Remove btn-group because of no use here (IMO)
Add div role="tooltip"

Testing Instructions

Dashboard > System > Redirects under Manage

If your site doesn't have any redirects, please create some redirects using New

Actual result BEFORE applying this Pull Request

tooltip-before.mp4

Expected result AFTER applying this Pull Request

tooltip-after.mp4

Documentation Changes Required

No

@Quy
Copy link
Contributor

Quy commented May 10, 2021

Duplicate id attribute.

33748

@rjharishabh
Copy link
Contributor Author

@Quy can I change cb to some other like ed

@Quy
Copy link
Contributor

Quy commented May 10, 2021

Please checkout Banners to see how it is done using aria-labelledby

@rjharishabh
Copy link
Contributor Author

Banners use this id="cbunpublish0-desc"

@Quy
Copy link
Contributor

Quy commented May 10, 2021

I’m not at a computer to confirm but yes that should be fine.

@chmst
Copy link
Contributor

chmst commented May 10, 2021

@rjharishabh you also con compare this one: #33557

@Quy
Copy link
Contributor

Quy commented May 10, 2021

Please add aria-labelledby attribute to the a tag.

@Quy
Copy link
Contributor

Quy commented May 10, 2021

I have tested this item ✅ successfully on 246a7af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33748.

1 similar comment
@ghost
Copy link

ghost commented May 11, 2021

I have tested this item ✅ successfully on 246a7af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33748.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33748.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 11, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 11, 2021
@chmst chmst merged commit 13a036e into joomla:4.0-dev May 12, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 12, 2021
@chmst
Copy link
Contributor

chmst commented May 12, 2021

Thanks!

@rjharishabh
Copy link
Contributor Author

Thanks

@rjharishabh rjharishabh deleted the tooltip-redirect branch May 12, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants