-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[4.0] Change tooltip style in articles #33839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Change tooltip style in articles #33839
Conversation
|
I have tested this item 🔴 unsuccessfully on af07820 Position of tooltip is different. With pr below end of link, without pr below mouse position:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839. |
|
@sandramay0905 I think it's by design |
|
I have tested this item ✅ successfully on af07820 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839. |
|
I have tested this item ✅ successfully on af07820 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839. |
|
As this pr mentions Joomla style tooltip may I ask where this is documented? There are several ways to implement tooltips and I missed this one. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839. |
Joomla style tooltip means tooltip style used in Joomla 4 now I will change the title |
|
You misunderstood! I am actually looking for the documentation that describes how to use Tooltips in Joomla. This has changed since Joomla 3 and I need to update some ancillary documentation. Your pr title was finr. |
|
Thanks |
|
It is absolutely not necessary to change titles to tooltips. It is a pointless exercise that would need to be done in a gazillion places. The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles. This PR should be reverted as its not correct. |
It is absolutely not necessary to change titles to tooltips. It is a pointless exercise with zero benefits that would need to be done in a gazillion places. The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.
|
I stopped using titles and tooltips some years ago after reading somewhere that they had accessibility issues (icons too). It would be nice to have some guidance (documentation) on where each could/should be/not be used in Joomla 4. I could write something if nothing exists but don't what the acceptable practice should be. |
|
There is nothing wrong with titles. Used correctly they are perfectly accessible |
|
The point is not so much accesibility here but to get a readable tip |
|
why? it serves zero purpose other than to clutter the ui |
If you are happy that this breaks accessibility then what has been the point in the last three years work |
It is absolutely not necessary to change titles to tooltips. It is a pointless exercise with zero benefits that would need to be done in a gazillion places. The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.


Summary of Changes
Change
titletotooltip,Add
aria-labelledbyinaTesting Instructions
Go to the articles page
Please test with both RTL and LTR
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No