Skip to content

Conversation

@rjharishabh
Copy link
Contributor

@rjharishabh rjharishabh commented May 13, 2021

Summary of Changes

Change title to tooltip,
Add aria-labelledby in a

Testing Instructions

Go to the articles page

Please test with both RTL and LTR

Actual result BEFORE applying this Pull Request

articles-before

Expected result AFTER applying this Pull Request

articles-after

Documentation Changes Required

No

@rjharishabh rjharishabh changed the title 4.0] Add Joomla style tooltip in articles [4.0] Add Joomla style tooltip in articles May 14, 2021
@ghost
Copy link

ghost commented May 14, 2021

I have tested this item 🔴 unsuccessfully on af07820

Position of tooltip is different. With pr below end of link, without pr below mouse position:

With PR Without PR
Screen Shot 2021-05-14 at 08 51 20 Screen Shot 2021-05-14 at 08 52 27

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.

@rjharishabh
Copy link
Contributor Author

@sandramay0905 I think it's by design

@ceford
Copy link
Contributor

ceford commented May 14, 2021

I have tested this item ✅ successfully on af07820

The tooltip is distinct and reasonably well-placed in LTR and RTL. I think exact styling is a separate issue. For example, the tooltip shows/disapperas/shows on traversing a title broken over two lines.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.

@ghost
Copy link

ghost commented May 14, 2021

I have tested this item ✅ successfully on af07820

Changed the result by comments above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 14, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 14, 2021
@ceford
Copy link
Contributor

ceford commented May 14, 2021

As this pr mentions Joomla style tooltip may I ask where this is documented? There are several ways to implement tooltips and I missed this one.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.

@rjharishabh
Copy link
Contributor Author

As this pr mentions Joomla style tooltip may I ask where this is documented? There are several ways to implement tooltips and I missed this one.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33839.

Joomla style tooltip means tooltip style used in Joomla 4 now

I will change the title

@rjharishabh rjharishabh changed the title [4.0] Add Joomla style tooltip in articles [4.0] Change tooltip style in articles May 14, 2021
@ceford
Copy link
Contributor

ceford commented May 14, 2021

You misunderstood! I am actually looking for the documentation that describes how to use Tooltips in Joomla. This has changed since Joomla 3 and I need to update some ancillary documentation. Your pr title was finr.

@rdeutz rdeutz merged commit afc3dff into joomla:4.0-dev May 14, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 14, 2021
@infograf768
Copy link
Member

Thanks
Please do same patch for other managers.

@brianteeman
Copy link
Contributor

It is absolutely not necessary to change titles to tooltips. It is a pointless exercise that would need to be done in a gazillion places.

The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.

This PR should be reverted as its not correct.

brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request May 14, 2021
It is absolutely not necessary to change titles to tooltips. It is a pointless exercise with zero benefits that would need to be done in a gazillion places.

The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.
@ceford
Copy link
Contributor

ceford commented May 14, 2021

I stopped using titles and tooltips some years ago after reading somewhere that they had accessibility issues (icons too). It would be nice to have some guidance (documentation) on where each could/should be/not be used in Joomla 4. I could write something if nothing exists but don't what the acceptable practice should be.

@brianteeman
Copy link
Contributor

There is nothing wrong with titles. Used correctly they are perfectly accessible

@rjharishabh rjharishabh deleted the article-tooltip-joomla-style branch May 14, 2021 11:19
@infograf768
Copy link
Member

The point is not so much accesibility here but to get a readable tip

@brianteeman
Copy link
Contributor

why? it serves zero purpose other than to clutter the ui

@brianteeman
Copy link
Contributor

The point is not so much accesibility here but to get a readable tip

If you are happy that this breaks accessibility then what has been the point in the last three years work

Quy pushed a commit that referenced this pull request May 15, 2021
It is absolutely not necessary to change titles to tooltips. It is a pointless exercise with zero benefits that would need to be done in a gazillion places.

The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants