Install Joomla with non-standard db_port#33
Merged
laoneo merged 6 commits intojoomla-projects:mainfrom Aug 30, 2024
Merged
Conversation
Update README overview commands (joomla-projects#20)
merge from head repository
Added skip tour (joomla-projects#27)
Improve README (joomla-projects#30)
merge head repository joomla-projects/joomla-cypress
This is one puzzle piece for joomla/joomla-cms#43902
This was referenced Aug 24, 2024
Closed
Contributor
|
Thanks! |
Contributor
|
with joomla-framework/database#310 no more needed |
4 tasks
Contributor
Author
I disagree. This PR is necessary because it translates the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one puzzle piece for joomla/joomla-cms#43902 – Installing Joomla with non-standard database port.
In the Joomla System Tests this PR is only working together with joomla/joomla-cms#43968.
With currently (August 2024) Joomla Web Installer it is only working for MariaDB and MySQL. It is not working for PostgreSQL.
Isolated only testable that it does not harm.
You could see this PR is already used as hack in Joomla Branches Tester. There you can see it working in
scripts/cypress.sh 44 localand running in theInstallation.cy.jsstep. If you revert the changes in filebranch_44/node_modules/joomla-cypress/src/joomla.jsthe Joomla Web Installer fails with: