merge head repository joomla-projects/joomla-cypress#8
Merged
muhme merged 5 commits intomuhme:mainfrom Aug 7, 2024
Merged
Conversation
When the files are deleted, the web server sometimes still delivers content and does not fail as expected with 404 - Not Found. In such cases, we try again one second later for 10 retries.
* Let checkForPhpNoticesOrWarnings speak
Sometimes a PHP problem message directly in the HTML code causes rendering problems and
makes the error message invisible in the browser and on the screenshot. With this change
the PHP problem message is shown.
See the change by sample. Before:
```
Test in frontend that the related items module
1) "after each" hook for "can display a list of related articles based on the metakey field"
0 passing (748ms)
1 failing
1) Test in frontend that the related items module
"after each" hook for "can display a list of related articles based on the metakey field":
AssertionError: expected true to equal false
Because this error occurred during a `after each` hook we are skipping all of the remaining tests.
at Context.eval (webpack://joomla/./node_modules/joomla-cypress/src/support.js:98:0)
```
After:
```
Test in frontend that the related items module
1) "after each" hook for "can display a list of related articles based on the metakey field"
0 passing (1s)
1 failing
1) Test in frontend that the related items module
"after each" hook for "can display a list of related articles based on the metakey field":
Error: Unwanted PHP Deprecated: " DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in <b>/Users/hlu/Desktop/no_backup/joomla-cms/libraries/src/Date/Date.php</b> on line <b>126</b>"
Because this error occurred during a `after each` hook we are skipping all of the remaining tests.
at Context.eval (webpack://joomla/./node_modules/joomla-cypress/src/support.js:116:0)
```
* The method documentation for @returns rewritten
* Merged skipTour into cancelTour - Deleted the skipTour command to avoid having to differentiate between the use of the cancelTour command for Joomla 5.1 and skipTour for Joomla >= 5.2. - Merged the preferably used skip button into cancelTour. - Waiting for the start button to handle the problem to wait after page load that the overlay is opened by JavaScript. - Using preferably the skip tour button (>= 5.2), only this button doesn't exist, the cancel button (Joomla 5.1) is used. - Deleted the 40 seconds timout as cancelTour follows doAdministratorLogin, which ensures page is loaded in checking '<h1>Home Dashboard'. Default 4 secs should be more than enough to open the JavaScript overlay. - Updated README.md including screenshot image * Added 'Welcome to Joomla!' screenshot
* Fix createMenuItem - Make it working for Joomla >= 5 - Implement language selection - Refactor method documentation and unify non-use of the semicolon * Pollish method documentation * Working on Joomla 4 * The method documentation for @returns rewritten * Omitted should('exist') as it looks like assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.