[cypress] Add db_port in Installation.cy.js#43968
Merged
laoneo merged 2 commits intojoomla:5.2-devfrom Oct 23, 2024
Merged
Conversation
This was referenced Aug 23, 2024
Contributor
|
Looks good to me. |
Member
|
See also my PR for the database framework: joomla-framework/database#310 . Would be good to know if the PR here still works with the changes from my framework PR. |
Contributor
|
from my testing result with joomla-framework/database#310 just set |
4 tasks
Contributor
|
I have tested this item ✅ successfully on 9c2a993 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43968. |
Member
|
Can you rebase this one to 5.2? |
Contributor
Author
|
Rebased on 5.2-dev and checked System Tests on macOS with MariaDB passed |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request as a puzzle piece of Issue #43902
Summary of Changes
In the installation step of the system tests, support for the configuration of the database port is added.
Testing Instructions
The only isolated test that can be carried out for this change is that it does no harm.
You could see this PR is already used as hack in Joomla Branches Tester. There you can see it working in
scripts/cypress.sh 44 localand running theInstallation.cy.jsstep. Without the change (you have to comment-out the change intests/System/integration/install/Installation.cy.jsthe Joomla Web Installer fails with:Actual result BEFORE applying this Pull Request
The System Tests installation step cannot set the database port.
Expected result AFTER applying this Pull Request
The System Tests installation step can set the database port.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed