Merged
Conversation
Overview of the commands and the associated functions and variables v1.0.3
muhme
added a commit
that referenced
this pull request
Jun 29, 2024
Sometimes a PHP problem message directly in the HTML code causes rendering problems and
makes the error message invisible in the browser and on the screenshot. With this change
the PHP problem message is shown.
See the change by sample. Before:
```
Test in frontend that the related items module
1) "after each" hook for "can display a list of related articles based on the metakey field"
0 passing (748ms)
1 failing
1) Test in frontend that the related items module
"after each" hook for "can display a list of related articles based on the metakey field":
AssertionError: expected true to equal false
Because this error occurred during a `after each` hook we are skipping all of the remaining tests.
at Context.eval (webpack://joomla/./node_modules/joomla-cypress/src/support.js:98:0)
```
After:
```
Test in frontend that the related items module
1) "after each" hook for "can display a list of related articles based on the metakey field"
0 passing (1s)
1 failing
1) Test in frontend that the related items module
"after each" hook for "can display a list of related articles based on the metakey field":
Error: Unwanted PHP Deprecated: " DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in <b>/Users/hlu/Desktop/no_backup/joomla-cms/libraries/src/Date/Date.php</b> on line <b>126</b>"
Because this error occurred during a `after each` hook we are skipping all of the remaining tests.
at Context.eval (webpack://joomla/./node_modules/joomla-cypress/src/support.js:116:0)
```
muhme
added a commit
that referenced
this pull request
Aug 6, 2024
* Let checkForPhpNoticesOrWarnings speak
Sometimes a PHP problem message directly in the HTML code causes rendering problems and
makes the error message invisible in the browser and on the screenshot. With this change
the PHP problem message is shown.
See the change by sample. Before:
```
Test in frontend that the related items module
1) "after each" hook for "can display a list of related articles based on the metakey field"
0 passing (748ms)
1 failing
1) Test in frontend that the related items module
"after each" hook for "can display a list of related articles based on the metakey field":
AssertionError: expected true to equal false
Because this error occurred during a `after each` hook we are skipping all of the remaining tests.
at Context.eval (webpack://joomla/./node_modules/joomla-cypress/src/support.js:98:0)
```
After:
```
Test in frontend that the related items module
1) "after each" hook for "can display a list of related articles based on the metakey field"
0 passing (1s)
1 failing
1) Test in frontend that the related items module
"after each" hook for "can display a list of related articles based on the metakey field":
Error: Unwanted PHP Deprecated: " DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in <b>/Users/hlu/Desktop/no_backup/joomla-cms/libraries/src/Date/Date.php</b> on line <b>126</b>"
Because this error occurred during a `after each` hook we are skipping all of the remaining tests.
at Context.eval (webpack://joomla/./node_modules/joomla-cypress/src/support.js:116:0)
```
* The method documentation for @returns rewritten
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview of the commands and the associated functions and variables v1.0.3