Skip to content

add db_port#34

Closed
alikon wants to merge 1 commit intojoomla-projects:mainfrom
alikon:patch-1
Closed

add db_port#34
alikon wants to merge 1 commit intojoomla-projects:mainfrom
alikon:patch-1

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Aug 25, 2024

@muhme
Copy link
Contributor

muhme commented Aug 25, 2024

This fails as changes in the Joomla Web Installer needs to be implemented first:

 AssertionError: Timed out retrying after 4000ms: Expected to find element: `#jform_db_port`, but never found it.

In my opinion, each piece of the puzzle must first work independently, as there are far too many dependencies:

  • joomla-cypress changes and creating a new release
  • Using joomla-cypress new release in Joomla dev branch
  • Change in Joomla Systems Tests
  • Changes in Joomla Web Installer
  • Change in the backend administration screen

And as ?fun fact?, with #33 there is an intermediate solution submitted for != pgsql with using the port if it is given

And why is db_port used in setErrorReportingToDevelopment?

@alikon
Copy link
Contributor Author

alikon commented Sep 1, 2024

with joomla-framework/database#310 no more needed

@alikon alikon closed this Sep 1, 2024
@alikon alikon deleted the patch-1 branch September 1, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants