Make marks to contain subpages and add geoshape docs#1
Make marks to contain subpages and add geoshape docs#1mattijn wants to merge 92 commits intojoelostblom:docs-revamp-5.0from mattijn:docs-revamp-5.0
Conversation
|
I went through this briefly and it looks great to me! I can do a more full review after vega#2566 is merged. I agree with your comment there and think it would be easier to review small PRs instead of extending the same one, but let's hear what Jake prefers. |
❌ Deploy Preview for spontaneous-sorbet-49ed10 failed.
|
|
I have wanted to experiment with deploy previews of documentation related PRs for a while so I setup one here on my fork to test. It seems to work well for this PR. Maybe we can add it to the real altair repo at a later stage so that it is easier to review how the documentation changes with a PR without the need to build locally. The changes you made show up nicely on the link above (https://deploy-preview-1--spontaneous-sorbet-49ed10.netlify.app/). |
|
Thats a nice approach of deploying previews. Locally it is a bit of a struggle with making changes and viewing them. |
|
Add a section on classifications:
And an example how to use an expression for rotation:
The page is becoming a bit slower for loading all the embedded charts.. |
|
Wow I love it! That section on classifications is really neat. Altair is going from the lacking geo-docs to having the best ones out there =D I noticed that the page is a bit slower too, I wonder if it is related to Netlify or if it is slow locally as well |
* Change to sphinx pydata theme * Update templates, css, and config for the pydata theme * Update index structure for the pydata theme * Move case studies and setup redirect * Point to Vega-Lite docs for mark properties * Add headings and reorganize order of sections and headings for clarity * Remove ToC dropdown error created from empty ToC * Improve ToC for galleries and move seattle weather to original location * Do not use rediraffe since it is now not needed Also move a couple of section inside conf.py * Rename API Reference topbar entry * Move the `...` button next to each chart * Add getting help landing page * Format to pass flake8 tests * Make gallery and mini-gallery paths relative so that images show up * Compute current copyright year * Use recommend way to install via pip Remove dollar sign for easy copy paste * Adjust title positioning for narrow screens/windows * Remove use of deprecated functionality from the documentation * Merge interactions 1 and 2 * Contrast variable and selection parameters in expression strings * Note how to use custom Panel callbacks with Altair selections * Add more succinct example of selecting columns from dropdowns * Make examples equivalent
* Pin selenium to avoid breakage from deprecation * Switch to double quotes
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
* Create a new heatmaps section * Update layered_heatmap_text.py * Update altairgallery.py * Update hexbins.py * Update binned_heatmap.py * Update hexbins.py * Update altairgallery.py * Update table_bubble_plot_github.py * Update wind_vector_map.py * Update layered_heatmap_text.py
…ga#2640) * Delete multiple_marks.py * Create line_chart_with_points_different_color.py * Update line_chart_with_points.py * Rename line_chart_with_points_different_color.py to line_chart_with_points_stroked.py
* docs: Fix a few typos There are small typos in: - altair/sphinxext/altairplot.py - altair/sphinxext/schematable.py - altair/utils/tests/test_mimebundle.py - doc/user_guide/display_frontends.rst Fixes: - Should read `required` rather than `requred`. - Should read `temporary` rather than `temporay`. - Should read `aspects` rather than `spects`. - Should read `render` rather than `rendeer`. * Fix typos Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
…ga#2647) * Move parallel coordinates to line charts section * Update normed_parallel_coordinates.py * Update line_chart_with_points.py * Move other charts into new advanced calculations section * Big C * Add back other charts Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
* Add line chart with interpolation * Switch line chart to points to use wheat data * Add stroked points * Tidy multi series line chart * Update multi_series_line.py * Update multi_series_line.py * Update line_chart_with_interpolation.py * Delete line_chart_with_stroked_points.py
* Update examples and tests to VL5 syntax * Fix typo
* added argmax example * Update line_chart_with_custom_legend.py Fixed y axis labeling * Apply suggestions from code review Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * Update code formatting Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
minor: update readme code
|
@mattijn Now that the original docs revamp that I was working on is merged, could you open up this PR towards the main altair repo instead of my fork? I think the material here is amazing and I want to make sure we don't lose it. I know there is connection to vega#2607 which I have been meaning to get to for some time, and for me it doesn't matter which one we review/merge first, whatever is easier for you. |
8 participants
This PR extent the marks in the user guide to contain subpages.
One subpage with documentation related to the
mark_geoshapeis included.ps. I forgot to add geopandas as dependency in the requirements.txt for the docs.