MAINT: Update examples and tests to VL5 syntax#2576
Merged
joelostblom merged 3 commits intovega:masterfrom Jul 6, 2022
Merged
Conversation
6 tasks
Contributor
Author
|
@mattijn Since we have been updating the examples quite a bit in the last few PRs, I rebased this one and think it is a good idea if we merge it soon so that it doesn't go out of sync too much with the main branch (even if some things might change later such as |
mattijn
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes all the warnings seen in the CI currently. I will go through the docs and do the same in my other PR, but I thought it was better to keep this separate for clarity.
One note is that once these are updated they will no longer work as tests for the older APIs. Maybe this is OK since the older APIs won't see any changes (although it might need to stay compatible with changes in other packages), but if it is deemed that we still need the old examples around, we could create a
gallery-vl4.17folder or something like that to use for test of older version.