Change naming to alt.param and alt.add_params#2656
Merged
mattijn merged 3 commits intovega:masterfrom Jul 12, 2022
ChristopherDavisUCI:master
Merged
Change naming to alt.param and alt.add_params#2656mattijn merged 3 commits intovega:masterfrom ChristopherDavisUCI:master
mattijn merged 3 commits intovega:masterfrom
ChristopherDavisUCI:master
Conversation
Contributor
|
Nice! The linting check presents one issue to be resolved: https://github.com/altair-viz/altair/runs/7285808845?check_suite_focus=true The conflict is around here: https://github.com/altair-viz/altair/pull/2656/files#diff-bbe4e187b18d242a366c820d023afd89041759cb96e4ec66c3f34559a72c2f9dR2229. It's understood that this will affect code in the wild of people already trying out the main branch. Therefore thanks again for working on this! |
Contributor
Author
|
Thanks @mattijn. Weird that the search-and-replace led to wrong formatting. (But then there was also a mistaken parameter still around that the flake8 check found.) I think those issues are corrected now. |
Contributor
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this pull request incorporates the naming changes suggested by @mattijn in #2598. I didn't come across anything subtle in making these changes; I mostly just used Find and Replace. Please let me know if there are aspects that need to be thought through more carefully!
Needless to say, this will break the code of anyone currently using
alt.parameteroralt.add_parameter.