Pin selenium to avoid doctest breakage from deprecation#2624
Pin selenium to avoid doctest breakage from deprecation#2624joelostblom merged 2 commits intovega:masterfrom
Conversation
mattijn
left a comment
There was a problem hiding this comment.
If I try locally I need double quotes.
pip install "selenium<4.3.0"Also documented here: https://docs.python.org/3/installing/index.html#basic-usage:
When using comparator operators such as >, < or some other special character which get interpreted by shell, the package name and the version should be enclosed within double quotes
|
Good catch! This is unexpected for me since most Unix shells expand variables within double quotes but not single quotes, and I would expect us to want the string to be passed literally to |
This should (hopefully) fix the failing HTML & PDF exporter tests in `test_reports.py`. See altair-viz/altair_saver#104 and vega/altair#2624 Closes DEV-7078
This should (hopefully) fix the failing HTML & PDF exporter tests in `test_reports.py`. See altair-viz/altair_saver#104 and vega/altair#2624 Closes DEV-7078
This should (hopefully) fix the failing HTML & PDF exporter tests in `test_reports.py`. See altair-viz/altair_saver#104 and vega/altair#2624 Closes DEV-7078
This should (hopefully) fix the failing HTML & PDF exporter tests in `test_reports.py`. See altair-viz/altair_saver#104 and vega/altair#2624 Closes DEV-7078
Altair's doctests are currently failing due to a deprecation in Selenium 4.3.0 which is a dependency of
altair-saver(as reported in altair-viz/altair_saver#104). Until there is a new release ofaltair-saverthat addresses this (maybe with altair-viz/altair_saver#105), this PR make sure we can run doctests by pinning the version ofselenium.There will likely still be confusion among people who use the altair-saver library directly until it sees a new release since selenium 4.3.0 seems to be the default version installed with
altair-savercurrently.