Tidy natural_disasters.py example#2643
Merged
mattijn merged 9 commits intovega:masterfrom Jul 4, 2022
Merged
Conversation
mattijn
reviewed
Jul 3, 2022
Contributor
mattijn
left a comment
mattijn
left a comment
There was a problem hiding this comment.
Its great you are digging through all the examples!
If we going to improve the enhancement of this chart, then maybe we can improve it even bit more (its a chart in the case-study section anyways).
See my in-line suggestions that you could accept to your liking.
If all changes are accepted it should resolve into the following:
I changed the following:
- Defined the x-axis as temporal, had to start the domain from 1899 to 2018 to get a tick at 1900 and a tooltip for 2017 values.
- Changed the format of legend and tooltip values.
- Provided a title in combination with a smaller sized subtitle.
- Included an offset on the y-axis labels so they won't overlap with the circles.
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Contributor
Author
|
Sure. I trust your judgement. I accepted all your proposals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2627
Before:
After:
