Restore Windows CI runs #6024
Restore Windows CI runs #6024
Conversation
basil
added
the
work-in-progress
|
Likely will hit test timeouts because the tests are detectably slower on Windows than on Linux |
basil
force-pushed
the
windows
branch
7 times, most recently
from
9dec7ba to
dcd3abc
Compare
|
Well with the changes from #6026 I got the smoke tests passing locally, but I can't seem to get past the unit tests in CI. The unit tests seem to hang at the end before the build proceeds to building the WAR and running the integration tests. Since I can't reproduce this locally any help would be appreciated. |
basil
force-pushed
the
windows
branch
4 times, most recently
from
c2d8109 to
f04c931
Compare
Interestingly enough the hang on CI was in |
basil
force-pushed
the
windows
branch
11 times, most recently
from
02e1af8 to
0ea06ba
Compare
basil
added
skip-changelog
|
1hr 20 slower than linux 😢 |
|
Caught a bug in #6025 before it ever shipped, so worth it I suppose |
basil
force-pushed
the
windows
branch
3 times, most recently
from
3e9e9f3 to
241fece
Compare
|
#4447 (comment) FTR |
| node(buildType == 'Linux' ? (jdk == 8 ? 'maven' : 'maven-11') : buildType.toLowerCase()) { | ||
| String agentContainerLabel = jdk == 8 ? 'maven' : 'maven-11' | ||
| if (buildType == 'Windows') { | ||
| agentContainerLabel += '-windows' |
There was a problem hiding this comment.
Do we really need four combinations? To save resources, and sometimes wall clock time, I think it would suffice to run, say, Linux builds on Java 11 and Windows builds on Java 8.
There was a problem hiding this comment.
Nah, I was planning to reduce this to two runs before marking this change as ready for review. But in the meantime I've been running the draft PR with 4 builds to shake out any flakiness.
BTW #6029
There was a problem hiding this comment.
before marking this change as ready for review
There was a problem hiding this comment.
My bad. I marked this as draft.
basil
force-pushed
the
windows
branch
11 times, most recently
from
e86f0f2 to
a0c748a
Compare
|
After shaking out flakiness for the past few days (weeks?) and merging several other preparatory PRs, I think this PR is finally ready to land. Yesterday's run passed on Java 8/11 on both Linux/Windows.
For now I am retaining the Linux Java 8 and 11 builds but adding a Windows Java 11 build. This tests the recommended use case (Java 11) on both Linux and Windows while also testing the compatibility use case (Java 8) just on Linux. Linux builds are fast, so running two of them has no effect on wall clock time. The idea would be to drop the Linux Java 8 build once we drop support for Java 8 (hopefully sooner rather than later) and replace it with a Java 17 build once that infrastructure exists. |
|
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks! |
basil
added
the
ready-for-merge
Downstream of #6026, #6029, #6030, #6034, #6035, and jenkinsci/jenkins-test-harness#357. With all those changes and with the topmost commit of this PR, the tests pass on Windows in CI.