Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release detached plugin class loaders on shutdown #6034

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

basil
Copy link
Member

@basil basil commented Dec 8, 2021

Similar to #6030, another minor bug noticed when running tests on Windows. PluginManager#stop releases the class loaders for active plugins, but not detached plugins (which are in the plugins list but not the activePlugins list). As such the class loaders for the detached plugins never get closed. This PR properly processes both lists.

Proposed changelog entries

  • Fix a resource leak when shutting down Jenkins.

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added the bug For changelog: Minor bug. Will be listed after features label Dec 8, 2021
@timja timja requested a review from a team December 8, 2021 21:30
@basil basil mentioned this pull request Dec 8, 2021
@basil
Copy link
Member Author

basil commented Dec 8, 2021

This PR was tested successfully in a passing Windows CI run in #6024.

@basil basil added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Dec 9, 2021
@basil basil requested a review from a team December 13, 2021 14:18
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to understand the diff but I think this is OK.

@basil
Copy link
Member Author

basil commented Dec 13, 2021

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

@basil basil added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 13, 2021
@timja timja merged commit 560136b into jenkinsci:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants