Release class loader when a plugin fails to load

[basil]

A minor bug I noticed while debugging some Windows test issues. When a plugin is successfully loaded, we properly release its class loader in PluginManager#stop, but we never do the same when a plugin fails to load. This is a legitimate (though minor) leak.

Proposed changelog entries

• Fix a resource leak when a plugin fails to load.

Proposed upgrade guidelines

N/A

Submitter checklist

• (If applicable) Jira issue is well described
• Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
  • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
• Appropriate autotests or explanation to why this change has no tests
• For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

• There are at least 2 approvals for the pull request and no outstanding requests for change
• Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
• Changelog entries in the PR title and/or Proposed changelog entries are correct
• Proper changelog labels are set so that the changelog can be generated automatically
• If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[basil]

This PR was tested successfully in a passing Windows CI run in #6024.

[jglick]

jenkins/core/src/main/java/hudson/PluginManager.java

Lines 2270 to 2286 in 165d559

	/**
	* Constructor for FailedPlugin when we do not have an associated PluginWrapper
	*/
	public FailedPlugin(String name, Exception cause) {
	this.name = name;
	this.cause = cause;
	this.pluginWrapper = null;
	}
	/**
	* Constructor for FailedPlugin when we know which PluginWrapper failed
	*/
	public FailedPlugin(PluginWrapper pluginWrapper, Exception cause) {
	this.name = pluginWrapper.getShortName();
	this.cause = cause;
	this.pluginWrapper = pluginWrapper;
	}

FTR

[basil]

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!