Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore some tests on Windows #6035

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Ignore some tests on Windows #6035

merged 1 commit into from
Dec 10, 2021

Conversation

basil
Copy link
Member

@basil basil commented Dec 8, 2021

These tests consistently fail on Windows, but I lack the interest to go further with debugging them and fixing them. A skipped test is better than a failing test, so let's skip these for now to help us more quickly reach the point where the test suite is running on Windows again.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added the skip-changelog Should not be shown in the changelog label Dec 8, 2021
@basil basil mentioned this pull request Dec 8, 2021
@basil
Copy link
Member Author

basil commented Dec 8, 2021

This PR was tested successfully in a passing Windows CI run in #6024.

@basil basil requested a review from a team December 9, 2021 17:56
@basil basil requested a review from a team December 9, 2021 20:30
@MarkEWaite
Copy link
Contributor

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

@MarkEWaite MarkEWaite added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 9, 2021
@basil basil merged commit cc6d8aa into jenkinsci:master Dec 10, 2021
@basil basil deleted the ignore-windows branch December 10, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants