GC before trying to delete the Jenkins home directory #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In draft state until I open a PR demonstrating that with this change the test suite passes on Windows. |
|
This PR was tested successfully in a passing Windows CI run in jenkinsci/jenkins#6024. |
timja
approved these changes
Dec 8, 2021
Co-authored-by: Tim Jacomb <[email protected]>
basil
added a commit
to basil/jenkins
that referenced
this pull request
Dec 10, 2021
basil
added a commit
to basil/jenkins
that referenced
this pull request
Dec 11, 2021
basil
added a commit
to basil/jenkins
that referenced
this pull request
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run
System.gc()after shutting down Jenkins and deleting the Jenkins home directory, but by then it is too late on Windows: deleting the Jenkins home directory may have already failed due to open files held by class loaders. This PR solves the problem by moving the GC to before we delete the Jenkins home directory.