-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single/Multiline Build History #1470
Single/Multiline Build History #1470
Conversation
d8a55d6
to
ff254d7
Compare
Thanks for coming back, but as I am new to jenkins-1.580.1-1.1.noarch , can you tell me which parameter in which file I need to change 768px to make it work? |
ff254d7
to
534328b
Compare
@saadi60pk sorry, I'm not sure I understand your question. Simply resize your browser? |
you want me to update the following code in browser? My browser is full window |
I didn't find the file "entries.jelly " on my jenkins installed linux server. From where I can find the file? |
@saadi60pk I am saying that you should try the changes that are in this pull request. They try to address the issues you are having. I'm hoping you do not need to make any code changes yourself. |
aaa7618
to
0c25943
Compare
@saadi60pk Just to reiterate the comment I added to the description of this PR... You can download and try the jenkins.war from the CI build of this PR. |
789e0df
to
4921b95
Compare
4921b95
to
cb9036c
Compare
Results of testing with PR build 1744: If the badges fit into their container, they now are no longer moved to a separate line. So the only thing that's left is potential model link confusion, and you mentioned you wanted to fix that. Build parameters look weird, but how they're displayed has always sucked. I didn't get any feedback on my suggestion in JENKINS-22311 unfortunately. |
One minor issue I just found: The mouseover effect of both the build entry and the widget border is removed when hovering the model link indicator. When few builds needed rearrangement, it looks almost like the widget is blinking when moving the pointer down the builds list near the model link indicators. https://dl.dropboxusercontent.com/u/29853/PR1470-model-link-hover.mov Personally I'd prefer if the hover border of the widgets were always shown (and no border effect on hover). The current one is too light, making it appear fuzzy. This is a very subjective preference though. |
@daniel-beck thanks for try it yet again Daniel. Appreciate it !! As for your suggestion on JENKINS-22311 ... seems like a good solution to me (I added a comment). I was aware of what you had planned for that so purposely did nothing with it on this. It can be handled in a separate change. |
EDIT Disregard the below issue. It was a regression (unexpected config change) in Jenkins itself. Fixed by following these instructions: https://issues.jenkins-ci.org/browse/JENKINS-22028?focusedCommentId=196090&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-196090 @tfennelly There seems to be a bug with how the new multi-line layout handles HTML. Prior to this new version, the "Pull Request Builder Plugin" would format builds like this: After upgrading to the new version, the raw HTML is shown like this: Let me know if there's a better place to log this. Thanks! |
@geekdave In general, the Jenkins issue tracker is the best place to report issues. Go to http://jenkins-ci.org and click 'Bug Tracker'. In this case, please make sure beforehand that you did not configure a different markup formatter in Manage Jenkins » Configure Global Security. It should probably be 'Raw HTML' or 'Safe HTML'. That said,
|
Thanks @daniel-beck - I edited my original post once I discovered the markup formatter config. I did not change it myself, but it seems that a Jenkins upgrade automatically switched the default value. |
@tfennelly It seems to be no longer possible to click the ball to go to the console output as well. Another victim of JS content rewrites? |
@tfennelly Users reported the HTML issue I mentioned above in JENKINS-26406. |
Main changes:
Note: You can download and try the jenkins.war from the CI build of this PR.
It puts all build details on a single line so long as none of the fields in the row overflow. If any of them overflow, it converts the row to be "multi-line" and then tries moving the data around to make it fit:
Build descriptions are always given a full line of their own, creating a multi-line.