Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single/Multiline Build History #1470

Merged
merged 1 commit into from
Nov 30, 2014

Conversation

tfennelly
Copy link
Member

Main changes:

  1. A more dynamic build history layout. This is the main change. See screenshot below.
  2. Left side-panel is now a fixed width for screens wider than 768px i.e. does not keep resizing as the screen width changes.

Note: You can download and try the jenkins.war from the CI build of this PR.

screenshot 2014-11-26 14 25 31

It puts all build details on a single line so long as none of the fields in the row overflow. If any of them overflow, it converts the row to be "multi-line" and then tries moving the data around to make it fit:

  1. It tries to put the build name and "controls" (stop, badges etc) on the first row of the multi-line, moving the "build-details" (date etc) down to a line of it's own.
  2. If Translation to Brasilian Portuguese Br #1 above fails (build name is too long), it gives all of the first line in the multi-line to the build name (wrapping if needed) and then tries fitting the "build-details" (date etc) and "controls" (stop, badges etc) together on the second row. .
  3. If Translation to Brasilian Portuguese Br #1 and Translation to Brasilian Portuguese Br #2 above fail (both name and details are too long), it gives a row to each of name, details and controls (stop, badges etc - if there are any), again wrapping as needed.
  4. If there are badges and they overflow, they too will be moved to a line of their own. See screenshot below.

Build descriptions are always given a full line of their own, creating a multi-line.

@tfennelly tfennelly force-pushed the single-multi-line-buildhist branch from d8a55d6 to ff254d7 Compare November 24, 2014 22:13
@ghost
Copy link

ghost commented Nov 24, 2014

Thanks for coming back, but as I am new to jenkins-1.580.1-1.1.noarch , can you tell me which parameter in which file I need to change 768px to make it work?

@tfennelly tfennelly force-pushed the single-multi-line-buildhist branch from ff254d7 to 534328b Compare November 24, 2014 22:51
@tfennelly
Copy link
Member Author

@saadi60pk sorry, I'm not sure I understand your question. Simply resize your browser?

@ghost
Copy link

ghost commented Nov 24, 2014

you want me to update the following code in browser? My browser is full window
core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly

@ghost
Copy link

ghost commented Nov 24, 2014

I didn't find the file "entries.jelly " on my jenkins installed linux server. From where I can find the file?
core/src/main/resources/hudson/widgets/BuildHistoryWidget/entries.jelly

@tfennelly
Copy link
Member Author

@saadi60pk I am saying that you should try the changes that are in this pull request. They try to address the issues you are having. I'm hoping you do not need to make any code changes yourself.

@tfennelly tfennelly force-pushed the single-multi-line-buildhist branch from aaa7618 to 0c25943 Compare November 25, 2014 08:22
@tfennelly
Copy link
Member Author

@saadi60pk Just to reiterate the comment I added to the description of this PR... You can download and try the jenkins.war from the CI build of this PR.

@tfennelly tfennelly force-pushed the single-multi-line-buildhist branch 4 times, most recently from 789e0df to 4921b95 Compare November 27, 2014 13:06
@tfennelly tfennelly force-pushed the single-multi-line-buildhist branch from 4921b95 to cb9036c Compare November 29, 2014 09:25
@daniel-beck
Copy link
Member

Results of testing with PR build 1744: If the badges fit into their container, they now are no longer moved to a separate line. So the only thing that's left is potential model link confusion, and you mentioned you wanted to fix that.

Build parameters look weird, but how they're displayed has always sucked. I didn't get any feedback on my suggestion in JENKINS-22311 unfortunately.

@daniel-beck
Copy link
Member

One minor issue I just found: The mouseover effect of both the build entry and the widget border is removed when hovering the model link indicator. When few builds needed rearrangement, it looks almost like the widget is blinking when moving the pointer down the builds list near the model link indicators.

https://dl.dropboxusercontent.com/u/29853/PR1470-model-link-hover.mov

Personally I'd prefer if the hover border of the widgets were always shown (and no border effect on hover). The current one is too light, making it appear fuzzy. This is a very subjective preference though.

@tfennelly
Copy link
Member Author

@daniel-beck thanks for try it yet again Daniel. Appreciate it !!

As for your suggestion on JENKINS-22311 ... seems like a good solution to me (I added a comment). I was aware of what you had planned for that so purposely did nothing with it on this. It can be handled in a separate change.

@tfennelly tfennelly merged commit cb9036c into jenkinsci:master Nov 30, 2014
daniel-beck added a commit that referenced this pull request Nov 30, 2014
@geekdave
Copy link

EDIT Disregard the below issue. It was a regression (unexpected config change) in Jenkins itself. Fixed by following these instructions: https://issues.jenkins-ci.org/browse/JENKINS-22028?focusedCommentId=196090&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-196090


@tfennelly There seems to be a bug with how the new multi-line layout handles HTML.

Prior to this new version, the "Pull Request Builder Plugin" would format builds like this:

image

After upgrading to the new version, the raw HTML is shown like this:

image

Let me know if there's a better place to log this. Thanks!

@daniel-beck
Copy link
Member

@geekdave In general, the Jenkins issue tracker is the best place to report issues. Go to http://jenkins-ci.org and click 'Bug Tracker'.

In this case, please make sure beforehand that you did not configure a different markup formatter in Manage Jenkins » Configure Global Security. It should probably be 'Raw HTML' or 'Safe HTML'.

That said,

  • HTML doesn't work for me correctly either (it is stripped rather than shown however). @tfennelly Possibly due to the text changes setting textContent?
  • The Pull Request Builder Plugin seems to assume you configured HTML markup formatting, which is a bad assumption (e.g. PegDown Formatter Plugin, or 'Escaped HTML'). If that's really the case, you could file a bug against that as well, if no such report exists yet.

@geekdave
Copy link

Thanks @daniel-beck - I edited my original post once I discovered the markup formatter config. I did not change it myself, but it seems that a Jenkins upgrade automatically switched the default value.

@daniel-beck
Copy link
Member

@tfennelly It seems to be no longer possible to click the ball to go to the console output as well. Another victim of JS content rewrites?

@daniel-beck
Copy link
Member

@tfennelly Users reported the HTML issue I mentioned above in JENKINS-26406.

@karisivo
Copy link

I tried to live with this new feature and I made a workaround by using PostBuildGroovy plugin. I set a shortext badge with html link and it first looks working well. But then I find a bug line wrapping not work in "Recent changes" page.
In job page:
normal_page
In "Recent Changes" page:
changes

And like you can see HTML not work on description. there is used br tag to made new lines, but everything is shown as one line.

This Recent changes page view is important to us as we need to see easily what is changed between each releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants