WIP: Remove pane tables in favor of CSS grids #3100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkmeneguello
force-pushed
the
flex-pane
branch
from
649e72a to
adff2ff
Compare
bkmeneguello
force-pushed
the
flex-pane
branch
from
adff2ff to
9f53112
Compare
|
|
Sure, I will.
I've made a comment in
https://wiki.jenkins-ci.org/display/JENKINS/Browser+Compatibility+Matrix,
if IE 11 is still the baseline for Windows browsers.
This PR is intentionally preliminary to raise this questions ASAP.
Em 19 de out de 2017 19:37, "Daniel Beck" <[email protected]>
escreveu:
… @bkmeneguello <https://github.com/bkmeneguello>
- Please provide before/after screenshots.
- Please ensure that you tested this change with
https://wiki.jenkins-ci.org/display/JENKINS/Browser+
Compatibility+Matrix
<https://wiki.jenkins-ci.org/display/JENKINS/Browser+Compatibility+Matrix>
- Please review the various changes in this area between 1.580 and
1.620 or so (#1466 <#1466>
#1470 <#1470> #1473
<#1473> #1542
<#1542> #1710
<#1710> #1836
<#1836> are the ones I was
able to find quickly), and make sure your change causes no problems with
any of the scenarios these earlier changes deal with.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQuOAhBqPYlZ0O5poTfelxU5YKNclZ1ks5st8EVgaJpZM4P_w6X>
.
|
Right, probably needs updating. I think there was a thread a while back on the dev list, but it didn't gain traction. |
|
I think it should aim the evergreen browsers. IE should be off at least
level 2 support.
Em 19 de out de 2017 19:48, "Daniel Beck" <[email protected]>
escreveu:
… if IE 11 is still the baseline for Windows browsers.
Right, probably needs updating. I think there was a thread a while back on
the dev list, but it didn't gain traction.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3100 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQuOKJIOI7NiEnjwSIX4spT4o2qLz4rks5st8O3gaJpZM4P_w6X>
.
|
daniel-beck
added
the
work-in-progress
|
|
bkmeneguello
commented
Oct 20, 2017
| </j:when> | ||
| <j:otherwise> | ||
| <!-- not actually optional, but it helps with backward compatibility --> | ||
| <j:set var="executor" value="${e}" /> | ||
| <table> |
There was a problem hiding this comment.
This should be avoided, but plugins uses executorCell.jelly starting directly with TD. I think this could be improved with an alternate "executorCell" (with fluid syntax) or PR to any plugin that have executorCell.jelly file
|
Oops, confused the executors panel with the build history of a job. Sorry about that. This one should be much more straightforward. |
bkmeneguello
force-pushed
the
flex-pane
branch
from
7ac7f5f to
3cc44b3
Compare
…we got a chance to even try scheduling a second.
…sk.getCauseOfBlockage.
…ge, which you needed to implement anyway.
…hot dependency on Remoting. (jenkinsci#3069)
* - add a default implementation doing nothing for the different event on SecurityListener. * - remove the useless non-implemented method in this inner class.
…n when data is "{}" (jenkinsci#3097)
* [JENKINS-47500] unit test for JENKINS-47500 bug
* [JENKINS-47500] return null when the data is just {}
* [JENKINS-47500] added more cases
|
I don't know what's going on, but this PR's history is messed up. Please re-file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.