Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle widget panes #8761

Merged
merged 9 commits into from
Dec 19, 2023
Merged

Restyle widget panes #8761

merged 9 commits into from
Dec 19, 2023

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Dec 7, 2023

Small PR to tweak the widget pane styles to be more inline with the rest of Jenkins. The goal is to clean up the design without taking away their compact nature.

Before
image

image

After
image

image

This relates to a wider rework which I'm seeking feedback on - see https://community.jenkins.io/t/revamped-build-history-widget/10944/5 and please give feedback!

Testing done

Widgets function as before

Proposed changelog entries

  • Restyle widget panes

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@NotMyFault NotMyFault requested a review from a team December 9, 2023 09:24
@NotMyFault NotMyFault added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Dec 9, 2023
@daniel-beck
Copy link
Member

daniel-beck commented Dec 11, 2023

Widgets function as before

Build 138 in screenshots demonstrates early unnecessary wrapping, so more work seems needed here. Some of what was shown in #1470 might make for good test cases.

@janfaracik
Copy link
Contributor Author

Tweaked the widths slightly, looks to be fine now.

Before
Screenshot 2023-12-13 at 22 07 34

After
Screenshot 2023-12-13 at 22 07 24

@daniel-beck daniel-beck self-requested a review December 14, 2023 08:31
@daniel-beck daniel-beck added the security-approved @jenkinsci/core-security-review reviewed this PR for security issues label Dec 14, 2023
@NotMyFault NotMyFault requested a review from a team December 15, 2023 11:53
@timja
Copy link
Member

timja commented Dec 16, 2023

Spacing looks off when there's extra widgets, e.g. cloud statistics:

image

The build queue has this which is why it wasn't noticed I guess:
image

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some things look a bit funny but they also look like that on the master branch. LGTM


/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 16, 2023
@timja timja merged commit cf81b9c into jenkinsci:master Dec 19, 2023
17 checks passed
@timja timja deleted the restyle-cards branch December 19, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants