Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the build history model link from the build date to name #1473

Merged
merged 1 commit into from
Dec 1, 2014

Conversation

tfennelly
Copy link
Member

  1. Move the build history model link from the build date to name
  2. Get the model link javascript code to update a parent element of the link target. This allows us to style the parent when the model link is active and so avoid weird model link mouse-over effects.

I didn't make this change as part of #1470 because I ran into what I thought was an issue at the time and decided to leave it. As it turns out, it works fine. Not sure what the issue was at the time but I thought the code behind the model link was screwing up the formatting in this case. I was doting.

@tfennelly tfennelly force-pushed the move-buildhist-model-link branch from 9605c34 to ad02371 Compare December 1, 2014 07:53
@daniel-beck
Copy link
Member

It looks like you need to adjust a test.

@tfennelly tfennelly force-pushed the move-buildhist-model-link branch from ad02371 to 679c127 Compare December 1, 2014 11:03
@tfennelly tfennelly merged commit 679c127 into jenkinsci:master Dec 1, 2014
@daniel-beck
Copy link
Member

Is there a reason for the date/time to still be a link now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants