fix: store tool version opts in .mise.backend#4960
Merged
Conversation
auto-merge was automatically disabled
April 28, 2025 15:41
Head branch was pushed to by a user without write access
roele
force-pushed
the
issues/playground-tool-version-opts
branch
from
173100f to
0a3a69a
Compare
roele
changed the title
roele
force-pushed
the
issues/playground-tool-version-opts
branch
from
0a3a69a to
4ec9038
Compare
Contributor
|
fwiw, I tested |
Contributor
Author
|
Thanks for verifying @efussi! Yes since this forces to store the full tool string in |
jdx
pushed a commit
that referenced
this pull request
Apr 29, 2025
### 🐛 Bug Fixes - **(aqua)** fix bin_path of tools in monorepo by [@risu729](https://github.com/risu729) in [#4954](#4954) - **(schema)** allow array of objects for hooks by [@risu729](https://github.com/risu729) in [#4955](#4955) - store tool version opts in .mise.backend by [@roele](https://github.com/roele) in [#4960](#4960) ### 📚 Documentation - add information about the DNF repository by [@acesyde](https://github.com/acesyde) in [#4956](#4956) ### 🧪 Testing - fix registry tools by [@jdx](https://github.com/jdx) in [#4959](#4959) ### Chore - **(deny)** added CDLA-Permissive-2.0 by [@jdx](https://github.com/jdx) in [#4961](#4961)
jdx
pushed a commit
that referenced
this pull request
May 26, 2025
According to the discussion #5001 the change #4960 to support GH Enterprise/GitLab is causing a regression for certain tools (e.g. aqua) because of the global ToolOption argument `postinstall`. To address this we should filter the global once on install arguments and only store ToolOptions for certain backends (`cargo`, `go`, `pipx`, `ubi`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less intrusive solution as replacement for #4886. This stores the tool options used when installing to the
fullrepresentation in.mise.backendwhich allows theBackendArgto properly parse and initialize the backend.That solves the following use case which currently fails because tool options are not available when tools are initialized from install state.