fix: installing tools with postinstall hooks fails#5191
Merged
Conversation
jdx
pushed a commit
that referenced
this pull request
May 26, 2025
### 🐛 Bug Fixes - installing tools with postinstall hooks fails by [@roele](https://github.com/roele) in [#5191](#5191) - prefer offline when executing shims by [@jdx](https://github.com/jdx) in [#5195](#5195) - multi-line task output is shown in bold by [@roele](https://github.com/roele) in [#5197](#5197) ### ⚡ Performance - improve tool loading performance in async code by [@jdx](https://github.com/jdx) in [#5198](#5198)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the discussion #5001 the change #4960 to support GH Enterprise/GitLab is causing a regression for certain tools (e.g. aqua) because of the global ToolOption argument
postinstall. To address this we should filter the global once on install arguments and only store ToolOptions for certain backends (cargo,go,pipx,ubi)