Skip to content

fix(aqua): fix bin_path of tools in monorepo#4954

Merged
jdx merged 3 commits into
jdx:mainfrom
risu729:fix-aqua-dir-tools
Apr 28, 2025
Merged

fix(aqua): fix bin_path of tools in monorepo#4954
jdx merged 3 commits into
jdx:mainfrom
risu729:fix-aqua-dir-tools

Conversation

@risu729

@risu729 risu729 commented Apr 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #4904.

For tools in a monorepo, we need to use the directory name instead of the repo name for bin_path.

e.g. mimirtool

# yaml-language-server: $schema=https://raw.githubusercontent.com/aquaproj/aqua/main/json-schema/registry.json
packages:
  - name: grafana/mimir/mimirtool
    type: github_release
    repo_owner: grafana
    repo_name: mimir
    description: Grafana Mimir provides horizontally scalable, highly available, multi-tenant, long-term storage for Prometheus
    asset: mimirtool-{{.OS}}-{{.Arch}}
    format: raw
    version_prefix: mimir-
    supported_envs:
      - linux
      - darwin

https://mise-versions.jdx.dev/aqua-registry/grafana/mimir/mimirtool/registry.yaml

@jdx jdx merged commit ec3d3de into jdx:main Apr 28, 2025
@mise-en-dev mise-en-dev mentioned this pull request Apr 28, 2025
Merged
jdx pushed a commit that referenced this pull request Apr 29, 2025
@mise-en-dev
chore: release 2025.4.12 (#4957)
f8a6fb7 
### 🐛 Bug Fixes

- **(aqua)** fix bin_path of tools in monorepo by
[@risu729](https://github.com/risu729) in
[#4954](#4954)
- **(schema)** allow array of objects for hooks by
[@risu729](https://github.com/risu729) in
[#4955](#4955)
- store tool version opts in .mise.backend by
[@roele](https://github.com/roele) in
[#4960](#4960)

### 📚 Documentation

- add information about the DNF repository by
[@acesyde](https://github.com/acesyde) in
[#4956](#4956)

### 🧪 Testing

- fix registry tools by [@jdx](https://github.com/jdx) in
[#4959](#4959)

### Chore

- **(deny)** added CDLA-Permissive-2.0 by [@jdx](https://github.com/jdx)
in [#4961](#4961)
@mise-en-dev mise-en-dev mentioned this pull request Apr 29, 2025
Merged
@glasser glasser mentioned this pull request Apr 30, 2025
Merged
5 tasks
@glasser

glasser commented Apr 30, 2025

Copy link
Copy Markdown
Contributor

commenting for searchability — if your installation of the tool kubelet is installing the binary as kubernetes, this is the fix (in 2025.4.12).

@risu729 risu729 deleted the fix-aqua-dir-tools branch May 23, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@risu729 @glasser @jdx