[jdx]

https://entire.io/gh/jdx/mise/trails/615

Follow-up to #14218, stacked on it (base is a copy of that PR's head, since its branch does not allow maintainer edits). Retarget to main once #14218 merges.

mise lock no longer clones the aqua package once per version candidate for packages whose version overrides have no version_prefix, which is nearly every package. In that case every candidate resolves to the root prefix, so there is nothing to disambiguate and the ambiguity pass is skipped.

Also:

• the ambiguous-prefix error now ends "no exact release tag matched", which is accurate for HTTP packages that never have a tag
• the ambiguity unit test is split from the known-tag test so each name describes what it asserts
• the e2e ambiguity case runs mise lock directly through assert_contains instead of echo '$output' with || true

Behavior is otherwise unchanged. Validated with the 123 aqua backend unit tests and test_lockfile_aqua_version_prefix_override.

🤖 Generated with Claude Code

AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: unavailable.

---

Note

Low Risk
Targeted lock-path optimization and clearer errors; ambiguity rejection is unchanged for packages that actually use override prefixes.

Overview
lock_package_for_version now runs the multi-prefix ambiguity check only when there is no release tag and at least one version_override defines a version_prefix. Packages without override prefixes skip the per-candidate pkg.clone() pass because every candidate shares the same root prefix—behavior stays the same, with less work on the common path.

The ambiguous-prefix error text now says "no exact release tag matched" (better for HTTP packages with no tags). Unit coverage splits the “known tag resolves” case from reject ambiguous prefixes without a tag; the lockfile e2e asserts the ambiguity message by running mise lock directly and notes that an unresolvable platform is reported while mise lock still exits 0.

^{Reviewed by Cursor Bugbot for commit 28adc57. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• Bug Fixes
  • Version-prefix ambiguity is now reported only when no exact release match is found, avoiding ambiguity reports when an exact version is available.
  • Locking now completes successfully when a platform cannot be resolved; that platform is reported and skipped.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: d8abd8ab-bd6c-4a91-87f2-dd42dd676d40

---

📥 Commits

Reviewing files that changed from the base of the PR and between 1e8000f and 28adc57.

---

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3b6de473-8b33-46e6-9b5e-c56cff9190bf

---

📥 Commits

Reviewing files that changed from the base of the PR and between 60a22f7 and 1e8000f.

---

📒 Files selected for processing (2)

• e2e/lockfile/test_lockfile_aqua_version_prefix_override
• src/backend/aqua.rs

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

---

---

📝 Walkthrough

Walkthrough

Aqua lockfile resolution now checks version-prefix ambiguity only when a version override defines a prefix and no exact release tag is resolved. Unit and end-to-end tests cover the resolution behavior.

Changes

Aqua lockfile resolution

Layer / File(s)	Summary
Version-prefix ambiguity detection src/backend/aqua.rs	The resolver checks for ambiguous prefixes only when no exact release tag is resolved and a version override defines a prefix. The ambiguity error wording also changes.
Resolution test coverage src/backend/aqua.rs, e2e/lockfile/test_lockfile_aqua_version_prefix_override	Unit tests separate known-tag resolution from no-tag ambiguity checks. The end-to-end test invokes mise lock directly and checks the reported output.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: nettlesh, jambalaya56562

---

Merge Risk: ⚪ Minimal · up to 1e800

No actionable merge-blocking risk is identified. Run the e2e test as part of normal validation.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: skipping the Aqua prefix ambiguity check when no override prefixes exist.

---

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 134c2c9. Configure here.}

[github-actions]

Instruction counts

benchmark	trend	instructions	Δ	wall (min)	Δ
env	▄▄▅▄▁▄▅▅█	27,935,022 → 27,991,109	+0.20%	19.19 → 19.08ms	-0.61%
hook-env	▇▇▇▇▁▇▇█▇	30,034,510 → 30,009,956	-0.08%	20.80 → 20.58ms	-1.05%
ls	▅▃▆▆▁▄▅▅█	32,136,304 → 32,209,358	+0.23%	21.13 → 21.61ms	+2.28%
registry	▂▃▃▃▁▃▃▂█	40,219,296 → 40,306,132	+0.22%	17.70 → 17.98ms	+1.63%
startup	▅█▇▄▁▅▄▄▆	11,076,662 → 11,091,647	+0.14%	12.37 → 12.30ms	-0.55%

No instruction-count regression above 1%.

_{Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.}

_{Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.}

_{28adc57e0328 vs 2ee2128c304a · measured on the runner, not pushed to the history.}