Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR bumps the ChangesRelease 2026.6.2
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryRelease 2026.6.2 bumps the version across all manifests and packages new/updated aqua-registry entries alongside a handful of bug-fixes and config features merged since 2026.6.1.
Confidence Score: 4/5Mostly a routine release bump; the one open question is whether attestation verification for the locked aube v1.16.1 artifacts will succeed now that all URLs point to jdx/aube while the original release was published under endevco/aube. The bulk of the change is mechanical (version bump, changelog, completion scripts, packaging files). The registry.yml updates are sourced from upstream aqua-registry and look well-formed. The unresolved concern — flagged in a prior review comment — is that mise.lock now has asset URLs under jdx/aube for v1.16.1 while the signer_workflow also references jdx/aube, but those artifacts were signed when the repo lived at endevco/aube. If mise verifies provenance strictly against the workflow reference, the check for v1.16.1 would fail. Everything else in the PR is straightforward. mise.lock — the aube attestation URL / signer_workflow alignment deserves a second look before merging. Important Files Changed
Reviews (16): Last reviewed commit: "chore: release 2026.6.2" | Re-trigger Greptile |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.1 x -- echo |
28.3 ± 3.2 | 21.5 | 41.5 | 1.00 |
mise x -- echo |
31.5 ± 4.2 | 23.9 | 70.9 | 1.11 ± 0.19 |
x -- echo measured 11% slower, but hyperfine reported statistical outliers. |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.1 env |
28.3 ± 3.6 | 21.4 | 43.7 | 1.00 |
mise env |
30.0 ± 3.6 | 23.3 | 50.5 | 1.06 ± 0.19 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.1 hook-env |
28.6 ± 2.9 | 22.0 | 42.4 | 1.08 ± 0.16 |
mise hook-env |
26.6 ± 2.7 | 21.4 | 37.7 | 1.00 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.1 ls |
19.3 ± 1.5 | 15.8 | 26.0 | 1.00 |
mise ls |
19.8 ± 1.4 | 16.7 | 28.6 | 1.03 ± 0.11 |
xtasks/test/perf
| Command | mise-2026.6.1 | mise | Variance |
|---|---|---|---|
| install (cached) | 160ms | 161ms | +0% |
| ls (cached) | 67ms | 69ms | -2% |
| bin-paths (cached) | 76ms | 78ms | -2% |
| task-ls (cached) | 145ms | 146ms | +0% |
mise-en-dev
force-pushed
the
release
branch
2 times, most recently
from
f46fa5a to
36868dc
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@vendor/aqua-registry/registry.yml`:
- Line 3825: Replace the Windows zip override src entries that currently read
"src: ggshield-{{trimV .Version}}-{{.Arch}}-{{.OS}}/ggshield" with "src:
ggshield-{{trimV .Version}}-{{.Arch}}-{{.OS}}/ggshield.exe" for the Windows (OS
== windows) zip overrides so the src path matches the archive file name; update
each override block that uses that src pattern.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ea07f82b-8e7f-406f-94d2-43a8a31c4bb5
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (12)
CHANGELOG.mdCargo.tomlREADME.mdcompletions/_misecompletions/mise.bashcompletions/mise.fishcompletions/mise.ps1default.nixpackaging/rpm/mise.specsnapcraft.yamlvendor/aqua-registry/metadata.jsonvendor/aqua-registry/registry.yml
✅ Files skipped from review due to trivial changes (5)
- vendor/aqua-registry/metadata.json
- default.nix
- completions/_mise
- Cargo.toml
- README.md
🚧 Files skipped from review as they are similar to previous changes (5)
- completions/mise.bash
- completions/mise.ps1
- completions/mise.fish
- snapcraft.yaml
- packaging/rpm/mise.spec
| files: | ||
| - name: ggshield | ||
| src: ggshield-{{trimV .Version}}-{{.Arch}}-{{.OS}}/ggshield.exe | ||
| src: ggshield-{{trimV .Version}}-{{.Arch}}-{{.OS}}/ggshield |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check the actual file structure in ggshield Windows release archives
echo "Checking ggshield v1.51.0 Windows archive structure..."
curl -sL "https://github.com/GitGuardian/ggshield/releases/download/v1.51.0/ggshield-1.51.0-x86_64-pc-windows-msvc.zip" -o /tmp/ggshield-win.zip
unzip -l /tmp/ggshield-win.zip | grep -E "ggshield(\.exe)?"
echo -e "\nChecking ggshield v1.50.0 (older version) Windows archive structure..."
curl -sL "https://github.com/GitGuardian/ggshield/releases/download/v1.50.0/ggshield-1.50.0-x86_64-pc-windows-msvc.zip" -o /tmp/ggshield-old-win.zip
unzip -l /tmp/ggshield-old-win.zip | grep -E "ggshield(\.exe)?"
rm -f /tmp/ggshield-win.zip /tmp/ggshield-old-win.zipRepository: jdx/mise
Length of output: 50365
🏁 Script executed:
#!/bin/bash
set -euo pipefail
check_version () {
local ver="$1"
local url="https://github.com/GitGuardian/ggshield/releases/download/v${ver}/ggshield-${ver}-x86_64-pc-windows-msvc.zip"
local zip="/tmp/ggshield-${ver}.zip"
echo "== ggshield v${ver} =="
curl -sL "$url" -o "$zip"
# List only filenames ending exactly with ggshield or ggshield.exe
unzip -Z1 "$zip" | grep -E '(^|/)ggshield(\.exe)?$' || true
rm -f "$zip"
}
check_version "1.51.0"
echo
check_version "1.50.0"Repository: jdx/mise
Length of output: 203
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the relevant registry.yml section around the mentioned lines
echo "=== registry.yml around lines 3810-3895 ==="
nl -ba vendor/aqua-registry/registry.yml | sed -n '3810,3895p'
# Find all occurrences of "ggshield" in the registry file
echo
echo "=== occurrences of ggshield in registry.yml ==="
rg -n "ggshield" vendor/aqua-registry/registry.yml | head -n 50
# Search repository code for windows_ext handling and src extraction semantics
echo
echo "=== search for windows_ext usage ==="
rg -n "windows_ext" . | head -n 50
echo
echo "=== search for aqua-registry src handling semantics ==="
rg -n "aqua-registry" . | head -n 50Repository: jdx/mise
Length of output: 157
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== registry.yml around lines 3810-3895 ==="
sed -n '3810,3895p' vendor/aqua-registry/registry.yml
echo
echo "=== occurrences of ggshield-related src patterns ==="
rg -n "src: ggshield-\{\{trimV" vendor/aqua-registry/registry.yml || true
echo
echo "=== occurrences of ggshield.exe in registry.yml ==="
rg -n "ggshield\.exe" vendor/aqua-registry/registry.yml || true
echo
echo "=== occurrences of windows_ext near ggshield overrides ==="
rg -n "windows_ext" vendor/aqua-registry/registry.yml | head -n 50 || trueRepository: jdx/mise
Length of output: 5972
Fix ggshield Windows src to match the archive (ggshield.exe)
The ggshield Windows release zips (v1.51.0 and v1.50.0) contain .../ggshield.exe and no plain .../ggshield entry. In vendor/aqua-registry/registry.yml, the Windows zip overrides at lines 3825, 3835, 3847, and 3873 still use src: ggshield-{{trimV .Version}}-{{.Arch}}-{{.OS}}/ggshield (missing .exe), so extraction will likely fail on Windows. Update those Windows src values to point at .../ggshield.exe.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@vendor/aqua-registry/registry.yml` at line 3825, Replace the Windows zip
override src entries that currently read "src: ggshield-{{trimV
.Version}}-{{.Arch}}-{{.OS}}/ggshield" with "src: ggshield-{{trimV
.Version}}-{{.Arch}}-{{.OS}}/ggshield.exe" for the Windows (OS == windows) zip
overrides so the src path matches the archive file name; update each override
block that uses that src pattern.
6227fd4 to
2eda842
Compare
2 participants
🚀 Features
🐛 Bug Fixes
📚 Documentation
🧪 Testing
📦️ Dependency Updates
📦 Registry
Chore
New Contributors
📦 Aqua Registry Updates
New Packages (10)
alibaba/open-code-reviewgrafana-cold-storage/grizzlyhashicorp/hcl/hclfmtjdx/aubejdx/pitchforkklauspost/asmfmtlexfrei/claudelinemacstadium.com/orka3openai/tartvisioncortex/vtracerUpdated Packages (2)
FiloSottile/ageGitGuardian/ggshield