docs: On Debian/Ubuntu, use extrepo for installing#10262
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughDocumentation across three guides introduces ChangesExtrepo Installation Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR replaces the manual GPG key + apt sources setup for Debian/Ubuntu with an
Confidence Score: 5/5Documentation-only change with no runtime code; safe to merge. All three changed files are Markdown documentation. The extrepo workflow is factually correct: extrepo enable writes a self-contained DEB822 sources file and copies the signing key into /var/lib/extrepo/keys/ at runtime, so removing the extrepo package afterward leaves apt configuration intact for the subsequent apt-get install mise. The BuildKit directive is present. No logic errors or broken instructions were found. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "Add Dockerfile syntax directive" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/getting-started.md`:
- Around line 54-56: Add an apt index refresh before installing extrepo: move or
insert a "sudo apt update" immediately before the "sudo apt install -y extrepo"
command so the package index is fresh when running the "sudo apt install -y
extrepo" step (ensure the sequence becomes "sudo apt update", "sudo apt install
-y extrepo", "sudo extrepo enable mise", "sudo apt update", "sudo apt install -y
mise").
In `@docs/installing-mise.md`:
- Around line 131-134: The install sequence runs sudo apt install -y extrepo
before refreshing APT indexes which can fail on clean/stale systems; update the
steps so you run sudo apt update (or sudo apt-get update) before installing
extrepo, then keep sudo extrepo enable mise, another sudo apt update -y, and
finally sudo apt install -y mise so packages are installed against a fresh
package index.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 37a3290e-780d-4343-baa4-2cc1951bd68f
📒 Files selected for processing (3)
docs/getting-started.mddocs/installing-mise.mddocs/mise-cookbook/docker.md
| sudo apt install -y extrepo | ||
| sudo extrepo enable mise | ||
| sudo apt update |
There was a problem hiding this comment.
Add an apt index refresh before installing extrepo.
At Line 54, sudo apt install -y extrepo is executed before any apt update. On stale/fresh systems this can fail to locate extrepo. Add an update first in this block.
Proposed doc fix
```sh
+sudo apt update
sudo apt install -y extrepo
sudo extrepo enable mise
sudo apt update
sudo apt install -y mise</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @docs/getting-started.md around lines 54 - 56, Add an apt index refresh
before installing extrepo: move or insert a "sudo apt update" immediately before
the "sudo apt install -y extrepo" command so the package index is fresh when
running the "sudo apt install -y extrepo" step (ensure the sequence becomes
"sudo apt update", "sudo apt install -y extrepo", "sudo extrepo enable mise",
"sudo apt update", "sudo apt install -y mise").
</details>
<!-- fingerprinting:phantom:triton:hawk -->
<!-- cr-comment:v1:8de5bbf6543ae295e3c52ef9 -->
<!-- This is an auto-generated comment by CodeRabbit -->
| sudo apt install -y extrepo | ||
| sudo extrepo enable mise | ||
| sudo apt update -y | ||
| sudo apt install -y mise |
There was a problem hiding this comment.
Fix apt command order for the extrepo flow.
At Line 131, the guide installs extrepo before refreshing apt indexes. This can break on clean/stale environments. Add sudo apt update before installing extrepo.
Proposed doc fix
```sh
+sudo apt update
sudo apt install -y extrepo
sudo extrepo enable mise
sudo apt update -y
sudo apt install -y mise</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @docs/installing-mise.md around lines 131 - 134, The install sequence runs
sudo apt install -y extrepo before refreshing APT indexes which can fail on
clean/stale systems; update the steps so you run sudo apt update (or sudo
apt-get update) before installing extrepo, then keep sudo extrepo enable mise,
another sudo apt update -y, and finally sudo apt install -y mise so packages are
installed against a fresh package index.
</details>
<!-- fingerprinting:phantom:triton:hawk -->
<!-- cr-comment:v1:27a0fac6bdd87137d6c6330c -->
<!-- This is an auto-generated comment by CodeRabbit -->
2 participants
Recently mise deb repository was added to Debian extrepo. This follow-up to #10248 proposes the following documentation changes:
extrepoon Getting Started and Installing Mise pages.curl | shinstalling but in the second example (for multi-user containers) shows alternative installing withextrepo.python@3.15cannot be found by mise. It's also in https://github.com/jdx/mise/blob/main/docs/lang/python.md so I didn't change it.Summary by CodeRabbit