Skip to content

chore(ci): ignore RUSTSEC-2026-0173 proc-macro-error2 advisory#10269

Merged
jdx merged 2 commits into
jdx:mainfrom
risu729:chore/ignore-proc-macro-error2-advisory
Jun 8, 2026
Merged

chore(ci): ignore RUSTSEC-2026-0173 proc-macro-error2 advisory#10269
jdx merged 2 commits into
jdx:mainfrom
risu729:chore/ignore-proc-macro-error2-advisory

Conversation

@risu729

@risu729 risu729 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Ignore new RUSTSEC-2026-0173 advisory for unmaintained proc-macro-error2
  • Fixes cargo deny check failures in CI (lint job)

proc-macro-error2 is a transitive dependency via age, mlua (vfox), tabled, and rops. There is no safe upgrade path yet; this mirrors the existing ignore for the original proc-macro-error advisory (RUSTSEC-2024-0370).

Test plan

  • CI lint job passes (cargo deny check)

Made with Cursor

Summary by CodeRabbit

  • Chores
    • Updated dependency security configuration to acknowledge an unmaintained transitive dependency without available upgrade options.

cargo deny fails on the new unmaintained advisory for proc-macro-error2,
a transitive dependency with no safe upgrade path yet.
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cd46d755-a9b0-4352-a9f0-45c0799fcbde

📥 Commits

Reviewing files that changed from the base of the PR and between 03e4c3d and bce0b74.

📒 Files selected for processing (1)
  • deny.toml

📝 Walkthrough

Walkthrough

The PR adds a single advisory suppression entry to deny.toml for RustSec advisory RUSTSEC-2026-0173. The advisory relates to an unmaintained dependency (proc-macro-error2) that is pulled transitively through the age, mlua, tabled, or rops crates with no available safe upgrade path.

Changes

Advisory Ignore Configuration

Layer / File(s) Summary
Add advisory ignore entry
deny.toml
New RustSec advisory ignore entry for RUSTSEC-2026-0173 added to suppress warnings on the unmaintained proc-macro-error2 transitive dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bunny hops through config files with care,
Finding advisories that linger in the air,
One more suppressed—RUSTSEC-2026—so fair,
The dependency tree stays safe with reason to spare! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding an ignore for RUSTSEC-2026-0173 in the deny.toml configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Suppresses the new RUSTSEC-2026-0173 advisory for the unmaintained proc-macro-error2 crate in cargo deny to unblock CI, mirroring the existing ignore for the original proc-macro-error advisory (RUSTSEC-2024-0370).

  • Adds one entry to the [advisories].ignore list in deny.toml with a clear reason string that names the affected transitive dependents (age, mlua, tabled, rops) and notes no safe upgrade path yet.

Confidence Score: 5/5

Safe to merge — single-line addition to a CI advisory suppresslist with no runtime impact.

The change touches only deny.toml, adding one structured ignore entry that follows the exact same format as the other entries in the file. The reason string accurately names the affected transitive crates and states there is no upgrade path, consistent with the project's established practice for unmaintained dependency advisories.

No files require special attention.

Important Files Changed

Filename Overview
deny.toml Adds a single ignore entry for RUSTSEC-2026-0173 (proc-macro-error2 unmaintained advisory), matching the format and rationale of all existing ignore entries.

Reviews (1): Last reviewed commit: "Merge branch 'main' into chore/ignore-pr..." | Re-trigger Greptile

@jdx jdx merged commit e0bab68 into jdx:main Jun 8, 2026
33 checks passed
@risu729 risu729 deleted the chore/ignore-proc-macro-error2-advisory branch June 8, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants