chore(release): vendor aqua registry from main#10286
Conversation
📝 WalkthroughWalkthroughThis PR adds a new Python validation script that ensures consistency between a vendored Aqua registry YAML and local Mise registry backend TOML files, then integrates it into the release workflow. The validator parses both data sources, compares Aqua package IDs, and reports any missing entries with exit code handling for automation. ChangesAqua Registry Validator
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
fb5c115 to
42eaa6c
Compare
Greptile SummaryChanges
Confidence Score: 4/5Safe to merge for a release-tooling-only change; the main risk is vendoring a transient The actual change is small and confined to the release script. Switching from tagged releases to Only Important Files Changed
|
| OLD_AQUA_REGISTRY_TAG="$(jq -r '.tag // empty' "$AQUA_REGISTRY_METADATA")" | ||
| fi | ||
| NEW_AQUA_REGISTRY_TAG="$(gh release view --repo "$AQUA_REGISTRY_REPO" --json tagName --jq .tagName)" | ||
| NEW_AQUA_REGISTRY_TAG="$(gh api "repos/$AQUA_REGISTRY_REPO/commits/main" --jq .sha)" |
There was a problem hiding this comment.
Pinning to
main instead of a tagged release
Fetching the latest commit SHA from aquaproj/aqua-registry's main branch means the vendored registry can include WIP or unreleased changes that have not gone through aqua-registry's own release testing. Between upstream releases, main may contain broken YAML, schema changes, or incomplete package entries. Previously the code used the latest tagged release (gh release view), which is a stable, explicitly tested snapshot. This trade-off deliberately accepts instability to keep packages fresher, but it could cause a mise release to ship a vendored registry that aqua-registry themselves haven't yet cut as stable.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.1 x -- echo |
23.8 ± 1.9 | 20.3 | 32.8 | 1.00 |
mise x -- echo |
26.1 ± 3.2 | 21.0 | 55.5 | 1.10 ± 0.16 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.1 env |
24.9 ± 1.9 | 21.0 | 33.6 | 1.00 |
mise env |
26.3 ± 2.2 | 21.0 | 38.2 | 1.06 ± 0.12 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.1 hook-env |
23.7 ± 1.7 | 19.8 | 32.1 | 1.00 |
mise hook-env |
26.4 ± 2.7 | 20.9 | 37.5 | 1.12 ± 0.14 |
hook-env measured 12% slower, but the relative uncertainty overlaps the 10% threshold. |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.1 ls |
19.1 ± 1.4 | 16.2 | 26.4 | 1.00 |
mise ls |
21.6 ± 1.8 | 17.0 | 31.7 | 1.13 ± 0.12 |
ls measured 13% slower, but the relative uncertainty overlaps the 10% threshold. |
xtasks/test/perf
| Command | mise-2026.6.1 | mise | Variance |
|---|---|---|---|
| install (cached) | 165ms | 168ms | -1% |
| ls (cached) | 75ms | 80ms | -6% |
| bin-paths (cached) | 88ms | 89ms | -1% |
| task-ls (cached) | 169ms | 171ms | -1% |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 42eaa6c. Configure here.
| OLD_AQUA_REGISTRY_TAG="$(jq -r '.tag // empty' "$AQUA_REGISTRY_METADATA")" | ||
| fi | ||
| NEW_AQUA_REGISTRY_TAG="$(gh release view --repo "$AQUA_REGISTRY_REPO" --json tagName --jq .tagName)" | ||
| NEW_AQUA_REGISTRY_TAG="$(gh api "repos/$AQUA_REGISTRY_REPO/commits/main" --jq .sha)" |
There was a problem hiding this comment.
Commit SHA breaks tag assertion
Medium Severity
The release script now records the upstream main commit SHA in metadata.json’s tag field, but baked-registry tests still require that value to start with v like an aqua-registry release tag. Once vendoring runs, test_baked_registry_metadata fails even though the registry content is valid.
Reviewed by Cursor Bugbot for commit 42eaa6c. Configure here.


Summary
maincommit instead of the latest tagged releasevendor/aqua-registry/metadata.jsonastag, so the vendored snapshot remains reproducible and existing build metadata keeps workingValidation
bash -n xtasks/release-plzaquaproj/aqua-registrymain tob2116015b48a040543836bbd35f8ca3a3313698eand confirmed that fetched registry containsrepo_owner: jdx/repo_name: aubewith theendevco/aubealiasThis PR was generated by an AI coding assistant.
Note
Low Risk
Release-script-only change; vendoring still pins a specific commit SHA in metadata with no runtime auth or data-path changes.
Overview
Updates
xtasks/release-plzso the vendoredaquaproj/aqua-registrysnapshot tracks upstreammaininstead of the latest GitHub release.NEW_AQUA_REGISTRY_TAGis now resolved viagh api …/commits/main(commit SHA) rather thangh release view. The same variable still drivesraw.githubusercontent.comfetches and is written tovendor/aqua-registry/metadata.jsonastag, so prep/release behavior and aqua changelog diffs stay keyed to a fixed ref.Reviewed by Cursor Bugbot for commit 42eaa6c. Bugbot is set up for automated code reviews on this repo. Configure here.