Strauss hack jt #17
Open
Strauss hack jt #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unclear what the real underlying issue is. Code comments give a possible explanation.
…otlib_standalone_compat fix: make standalone work with matplotlib >= 3.9.0
…cope#2934) * support exporting a plot from an unopened/inactive plugin * prevent clearing plot selection (under most conditions)
Sync notebook github links in HTML docs to the git commit used to build them
* BUG: Specviz to respect local_path and timeout when provided
…traction.py Co-authored-by: Kyle Conroy <[email protected]>
--------- Co-authored-by: Katherine Carver <[email protected]> Co-authored-by: P. L. Lim <[email protected]> Co-authored-by: Kyle Conroy <[email protected]> Co-authored-by: Ricky O'Steen <[email protected]>
…orientation-dropdown Exclude subsets from WCS-only layer filter
* Use normalize_filename and overwrite_warn for plugin plots * Clear overwrite warning overlay after confirming * Changelog * Codestyle
* Markers: Save to CSV * Mark block as uncovered for coverage * Remove unused entries from _dict * Update CHANGES.rst Co-authored-by: Kyle Conroy <[email protected]> --------- Co-authored-by: Kyle Conroy <[email protected]>
…escope#2941) * Create private method for importing spectral region objects * Address review comments * Add tests for list of modes and single SpectralRegion * Fix style
Co-authored-by: Kyle Conroy <[email protected]>
…-test Fix for Imviz parser romandeps test after update to defaults
Changelog update for release of v3.10.3
…extract Bugfix for flux unit conversion in spectral cubes
* UI functioning unit conversion, need to reconcile tests * update syntax, remove unnecessary logic * tests now pass, API functionality improved * add additional equivalencies for coords info * first pass at disabling specviz translations * Remove dev flag, consolidate untranslatable units, multi-config support, styling changes * Refactor moment map unit conversion to not require spectrum, so nothing to centralize now. Fix devdeps Simplify flux_conversion logic and other minor fixes. Add flux conversion tests. Clarify which one should be reverted in the future * Remove SB/flux conversion for moment map because moment map always in SB * add os import * remove duplicate import from rebase * reconcile tests, change hints/docs, handle dimensionless case * emit GlobalDisplayUnitChanged msg when toggling SB<>flux * resolve most tests * temporarily remove translation message * add comments, reenable global display message, resolve tests * force sb unit for line flux test * add comments, clarify naming, add case handling for args * remove args and loop, replaced with msg * consolidate 2 translator functions into 1, consolidate _translate and _on_flux_unit_changed * address test failures * update marks.py equivalencies, resolving UnitConversion errors * make sure not only translation equivalencies are in marks.py but also conversions * add test coverage * use astropy units, small logic tweaks, cache untranslatable units * technical review changes * add warning message in tray if PIXAR_SR not present in FITS header * second pass at technical changes * move flux_unit checks to beginning of _on_flux_unit_changed * change _unit to flux.unit --------- Co-authored-by: P. L. Lim <[email protected]> Co-authored-by: Kyle Conroy <[email protected]>
…telescope#3101) * TST: Also run slow test in non-dev env * BUG: Fix table I/O in Catalog Search * ID as string always * Force ID to be always str even from file
…ope#3114) * MNT: Remove unnecessary astropy version checks * TST: Update model doctest
…pacetelescope#3113) * Enabling model fitting results to convert between flux and surface brightness * Switch to using selected_obj, clean up pixel scale retrieval * Changelog * Don't store pixel scale factor * Fix missing variable * Update test value due to updated pixel scale factor
* generalize use of term "spectrum" * move code to allow importing slice mixins without circular imports * is_slice_indicator filter for extract results instead of relying on a spectrum viewer existing and being set * attach marks to slice_indicator_viewers[0] instead of spectrum_viewer (temporarily to just the first instance, later we'll make this more flexible to allow any number of slice indicator viewers) * remove reliance on loaded_flux_cube * rename (internal) spectral_cube -> cube * generalize logic for setting disabled_msg * generalize internal marks names * generalize some internal traitlet names * update disabled message to specify cube * update tests for renamed marks/method * generalize logic within live-preview and extract * allow skipping wavelength-dependence * hide aperture masking method for entire cube and no bg * fix (and allow disabling) bg export * fix updating live preview on change to subset * skip updating marks if not tray instance
MNT: Remove unnecessary astropy check.
…escope#3121) * remove "Imviz" from "Line Profiles XY" plugin name with deprecation * changelog entry
spacetelescope#2931) * Respond to changed unit and display on the UI * Convert all sb<>sb units listed in the dropdown menu * Use the default current unit from the cube * Apply only for relevant configs * Update current_unit setting logic * Fix failing tests * Add tests * Add a changelog * Move conversion logic to utils * Move the conversion to utils * Pass when unable to convert * Update tests * Update based on the feedback * Only subscribe to cubeviz * Check for equivalency rather than image dimension * Refactor conversion logic Co-authored-by: P. L. Lim <[email protected]> * Rename unit and broadcast 'sb' as part of msg * Code style --------- Co-authored-by: P. L. Lim <[email protected]>
TST: Fix tests downloading data into source dir, MNT: Remove unnecessary astropy check
to write out fitted cube. This uses astropy/specutils#1051
Cubeviz to use wcs1d-fits from specutils to write out fitted cube
* Avoid checking selected_obj before it's available * Changelog * Added a test that fails on main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strauss-hackmay need rebasing to this commit:james-trayford@09c3cc6
To show the sonification changes alone - I this incorporates some of the later BUGFIXes from the
spacetelescopemain branchDescription
This pull request is to address ...
Fixes #
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.