"Imviz Line Profiles (XY)" renamed to "Image Profiles (XY)"

[kecnry]

Description

This pull request renames "Imviz Line Profiles (XY)" to "Line Profiles (XY)" "Image Profiles (XY)" along with deprecation for API access (although the plugin API itself is still not exposed).

If we want to name this to something more general (especially if we would ever want to re-use this for 2d spectra and want to avoid confusion with spectral lines) now would be the time to do so.

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[kecnry]

I think these have now been more than 2 releases, so maybe we can remove for 4.0?

[kecnry]

(I don't think that belongs in scope here, so I made a note in the 4.0 release ticket)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (3de1b08) to head (65adcf1).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3121      +/-   ##
==========================================
+ Coverage   88.91%   88.93%   +0.01%     
==========================================
  Files         111      112       +1     
  Lines       17365    17399      +34     
==========================================
+ Hits        15440    15473      +33     
- Misses       1925     1926       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pllim]

Any downstream notebooks need updating to go with this?

[kecnry]

Any downstream notebooks need updating to go with this?

Not that I know, there is currently no API access besides showing/opening the plugin, so I doubt any notebook makes use of this. If it does, they'll start seeing the "deprecation" message and hopefully know how to update before we remove that.

[pllim]

Looks uncontroversial enough. Thanks!

[kecnry]

(let's not merge until we have a chance to discuss generalizing the name - just canceled auto-merge)

[pllim]

Oh OK... I thought the ticket was pretty clear. Sorry if I misunderstood.

[kecnry]

@pllim - I did find one mention in a concept notebook and updated that here along with changing to "Image Profiles (XY)" as discussed offline. Are you ok with marking this as trivial and merging from your previous approval?

[pllim]

LGTM. Thanks!