Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix tests downloading data into source dir, MNT: Remove unnecessary astropy check #3122

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jul 30, 2024

Description

TST: Fix tests downloading data into source dir.

MNT: Remove unnecessary astropy check.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

MNT: Remove unnecessary astropy check.
@pllim pllim added bug Something isn't working testing trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Jul 30, 2024
@pllim pllim added this to the 4.0 milestone Jul 30, 2024
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (682e302) to head (e26b9ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3122      +/-   ##
==========================================
- Coverage   88.92%   88.89%   -0.04%     
==========================================
  Files         112      112              
  Lines       17396    17399       +3     
==========================================
- Hits        15470    15466       -4     
- Misses       1926     1933       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@pllim pllim merged commit ec0720b into spacetelescope:main Jul 30, 2024
36 of 37 checks passed
@pllim pllim deleted the moar-code-cleanup branch July 30, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cubeviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants