Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix standalone build events for PR #2946

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix standalone build events for PR #2946

merged 1 commit into from
Jul 9, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Jul 9, 2024

Description

This pull request is to make sure standalone build fires off properly when label is applied in PR.

@pllim pllim added bug Something isn't working trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive backport-v3.10.x on-merge: backport to v3.10.x labels Jul 9, 2024
@pllim pllim added this to the 3.10.3 milestone Jul 9, 2024
@pllim pllim added the Build standalone Additional pylons label Jul 9, 2024
@pllim
Copy link
Contributor Author

pllim commented Jul 9, 2024

No need to wait for CI. The job started and that is all that matters. Thanks for the quick review!

@pllim
Copy link
Contributor Author

pllim commented Jul 9, 2024

Ooops forgot I cannot admin override anymore. @rosteen , can you please merge this with your power? Thanks!

@rosteen rosteen merged commit e65237f into main Jul 9, 2024
33 of 43 checks passed

This comment was marked as resolved.

@pllim pllim deleted the pllim-patch-1 branch July 9, 2024 15:28
@pllim
Copy link
Contributor Author

pllim commented Jul 9, 2024

See #2947 for "backport"

javerbukh pushed a commit to javerbukh/jdaviz that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v3.10.x on-merge: backport to v3.10.x bug Something isn't working Build standalone Additional pylons no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants