Fix for Imviz parser romandeps test after update to defaults #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorris3
added
trivial
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3098 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 111 111
Lines 17262 17274 +12
=======================================
+ Hits 15317 15328 +11
- Misses 1945 1946 +1 ☔ View full report in Codecov by Sentry. |
bmorris3
requested review from
rosteen,
javerbukh,
pllim,
kecnry,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
bmorris3
force-pushed
the
fix-roman-parser-test
branch
from
c7bf942
to
6b7f233
Compare
kecnry
approved these changes
Jul 19, 2024
| ('data', 1), | ||
| (['data', 'var_rnoise'], 2)]) | ||
| def test_roman_wfi_ext_options(imviz_helper, roman_imagemodel, ext_list, n_dc): | ||
| imviz_helper.load_data(roman_imagemodel, data_label='roman_wfi_image_model', ext=ext_list) | ||
| dc = imviz_helper.app.data_collection | ||
| assert len(dc) == n_dc | ||
|
|
||
| if ext_list is None: | ||
| if ext_list == '*': |
There was a problem hiding this comment.
should this be covered in the test matrix?
There was a problem hiding this comment.
I'm going to say let's worry about coverage here once we have functionality that requires this behavior.
Co-authored-by: Kyle Conroy <[email protected]>
|
Remaining failures unrelated, merging. Thanks! |
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Jul 22, 2024
…after update to defaults
bmorris3
added a commit
that referenced
this pull request
Jul 22, 2024
…8-on-v3.10.x Backport PR #3098 on branch v3.10.x (Fix for Imviz parser romandeps test after update to defaults)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #2767 I corrected the ASDF extensions loaded by default in the Imviz parser. The optional Imviz parser tests for Roman data products hadn't been updated to match. I fixed them in this PR.
This PR needs the
Extra CIlabel to run the Roman tests. That means the link check also gets run on this PR, so I've also discovered and fixed some broken links in this same PR.Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.