Skip to content

Disable imageDigest support in ztunnel controller#582

Merged
istio-testing merged 2 commits intoistio-ecosystem:mainfrom
sridhargaddam:issue-581
Jan 28, 2025
Merged

Disable imageDigest support in ztunnel controller#582
istio-testing merged 2 commits intoistio-ecosystem:mainfrom
sridhargaddam:issue-581

Conversation

@sridhargaddam
Copy link
Copy Markdown
Contributor

@sridhargaddam sridhargaddam commented Jan 23, 2025 •
edited
Loading

Currently, we have some pending work with the ztunnel images that are used as imageDigests. Because of this, when deploying Ambient profile using the OSSM operator, the ztunnel pod fails to come up. This PR temporarily disables this functionality until proper support is implemented.

Alternatives:

  1. Default Image: If image details are not provided in the ZTunnel CR, the operator will use the default image from the helm chart.
  2. Explicitly specify image details: Following a recent fix in the ztunnel controller (PR#568), users can specify image details within the ztunnel CR itself in one of the following ways.
    2.1: ztunnel.spec.values.ztunnel.image
    2.2: ztunnel.spec.values.global.hub/tag

Note: This change impacts on the Ztunnel image when using the Ambient profile and will not have any affect on other images.

Fixes: #581

@sridhargaddam sridhargaddam requested a review from a team as a code owner January 23, 2025 12:29
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.43%. Comparing base (3955258) to head (faa5877).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
controllers/ztunnel/ztunnel_controller.go 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   74.65%   74.43%   -0.22%     
==========================================
  Files          40       40              
  Lines        2505     2511       +6     
==========================================
- Hits         1870     1869       -1     
- Misses        542      554      +12     
+ Partials       93       88       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nyechiel
Copy link
Copy Markdown

nyechiel commented Jan 24, 2025

It is important to note that this only impacts the Ambient profile, and not any usage of non-Ambient mode.

dgn
dgn reviewed Jan 24, 2025
View reviewed changes
@sridhargaddam
Copy link
Copy Markdown
Contributor Author

sridhargaddam commented Jan 27, 2025

/test scorecard

@sridhargaddam sridhargaddam requested a review from dgn January 27, 2025 11:57
@sridhargaddam
Disable imageDigest support in ztunnel controller
6fa6f0b 
Currently, we have some pending work with the ztunnel images that
are used as imageDigests. Because of this, when deploying Ambient
profile using the OSSM operator, the ztunnel pod fails to come up.
This PR temporarily disables this functionality until proper support
is implemented.

Alternatives:
1. Default Image: If no image details are provided in the ZTunnel CR,
   the operator will use the default image from the helm chart.
2. Explicitly specify image details: Following a recent fix in the
   ztunnel controller (PR#568), users can specify image details within
   the ztunnel CR itself in one of the following ways.
   2.1: ztunnel.spec.values.ztunnel.image
   2.2: ztunnel.spec.values.global.hub/tag

Fixes: istio-ecosystem#581
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@sridhargaddam
Use t.Skip() instead of Pending
faa5877 
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@sridhargaddam
Copy link
Copy Markdown
Contributor Author

sridhargaddam commented Jan 28, 2025

@dgn, I've updated the PR. PTAL, thanks.

@istio-testing istio-testing merged commit c282873 into istio-ecosystem:main Jan 28, 2025
@sridhargaddam
Copy link
Copy Markdown
Contributor Author

sridhargaddam commented Jan 29, 2025

/cherry-pick release-1.0

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 29, 2025

@sridhargaddam: new pull request created: #596

Details

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing istio-testing mentioned this pull request Jan 29, 2025
Merged
sridhargaddam added a commit that referenced this pull request Jun 12, 2025
@sridhargaddam
Revert "Disable imageDigest support in ztunnel controller (#582)"
ea893db 
This reverts commit c282873.
sridhargaddam added a commit that referenced this pull request Jun 12, 2025
@sridhargaddam
Revert "Disable imageDigest support in ztunnel controller (#582)"
2872951 
This reverts commit c282873.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
istio-testing pushed a commit that referenced this pull request Jun 16, 2025
@sridhargaddam
Revert "Disable imageDigest support in ztunnel controller (#582)" (#905)
72035af 
This reverts commit c282873.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 16, 2025
Automated merge
02ef3a2 
* upstream/main: (27 commits)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  Docs: adding istiod HA documentations (istio-ecosystem#865)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 16, 2025
Automated merge
118ebbe 
* upstream/main: (27 commits)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  Docs: adding istiod HA documentations (istio-ecosystem#865)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 16, 2025
Automated merge
116df25 
* upstream/main: (27 commits)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  Docs: adding istiod HA documentations (istio-ecosystem#865)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 16, 2025
Automated merge
89823cd 
* upstream/main: (27 commits)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  Docs: adding istiod HA documentations (istio-ecosystem#865)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 17, 2025
Automated merge
e987afc 
* upstream/main: (27 commits)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  Docs: adding istiod HA documentations (istio-ecosystem#865)
  ...
istio-testing pushed a commit to istio-testing/sail-operator that referenced this pull request Jun 17, 2025
@sridhargaddam @istio-testing
Revert "Disable imageDigest support in ztunnel controller (istio-ecos…
a5af12c 
…ystem#582)"

This reverts commit c282873.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
istio-testing added a commit that referenced this pull request Jun 17, 2025
@istio-testing @sridhargaddam
Revert "Disable imageDigest support in ztunnel controller (#582)" (#915)
6d6dfb1 
This reverts commit c282873.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 17, 2025
Automated merge
c5a591e 
* upstream/main: (27 commits)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  Docs: adding istiod HA documentations (istio-ecosystem#865)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 17, 2025
Automated merge
3d1dd9b 
* upstream/main: (27 commits)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  Docs: adding istiod HA documentations (istio-ecosystem#865)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 17, 2025
Automated merge
d76ec27 
* upstream/main: (27 commits)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  Docs: adding istiod HA documentations (istio-ecosystem#865)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 18, 2025
Automated merge
164ed4b 
* upstream/main: (27 commits)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  Docs: adding istiod HA documentations (istio-ecosystem#865)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 18, 2025
Automated merge
af2b2b8 
* upstream/main: (27 commits)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  Docs: adding istiod HA documentations (istio-ecosystem#865)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 18, 2025
Automated merge
bb554b9 
* upstream/main: (28 commits)
  Fix docs for "broken_links" workflow (istio-ecosystem#918)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  Adding description for release workflow run (istio-ecosystem#868)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 18, 2025
Automated merge
4b35ea2 
* upstream/main: (29 commits)
  e2e allow to build and push setting target arch (istio-ecosystem#913)
  Fix docs for "broken_links" workflow (istio-ecosystem#918)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881)
  Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877)
  chore(docs): cleans up IstioCNI section (istio-ecosystem#867)
  Force push to operator hub fork (istio-ecosystem#873)
  Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jun 18, 2025
Automated merge
0750585 
* upstream/main: (34 commits)
  Update VERSIONS_YAML_FILE e2e test information (istio-ecosystem#916)
  Improve automated docs test run (istio-ecosystem#894)
  Use `Eventually` in remote secret generation (istio-ecosystem#921)
  Docs followup link fix (istio-ecosystem#919)
  Fix helm issue during e2e test run  operator installation (istio-ecosystem#914)
  e2e allow to build and push setting target arch (istio-ecosystem#913)
  Fix docs for "broken_links" workflow (istio-ecosystem#918)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  ...
istio-testing pushed a commit to istio-testing/sail-operator that referenced this pull request Jun 19, 2025
@sridhargaddam @istio-testing
Revert "Disable imageDigest support in ztunnel controller (istio-ecos…
2793f5e 
…ystem#582)"

This reverts commit c282873.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
FilipB pushed a commit to FilipB/sail-operator that referenced this pull request Dec 1, 2025
@openshift-service-mesh-bot
[release-3.1] Automator: Update Istio module (istio-ecosystem#582)
41c9698 
Co-authored-by: openshift-service-mesh-bot <null>
dgn pushed a commit to dgn/sail-operator that referenced this pull request Mar 17, 2026
@sridhargaddam @dgn
Revert "Disable imageDigest support in ztunnel controller (istio-ecos…
283ede5 
…ystem#582)" (istio-ecosystem#905)

This reverts commit c282873.

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxun yxun yxun approved these changes

@dgn dgn dgn approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable imageDigest support using annotations in ztunnel controller

5 participants

@sridhargaddam @nyechiel @istio-testing @yxun @dgn