Consolidate multicluster operator deploy/cleanup#902
Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom Jun 12, 2025
Merged
Consolidate multicluster operator deploy/cleanup#902istio-testing merged 1 commit intoistio-ecosystem:mainfrom
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
- Coverage 76.31% 76.16% -0.15%
==========================================
Files 44 44
Lines 2685 2685
==========================================
- Hits 2049 2045 -4
- Misses 543 546 +3
- Partials 93 94 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Now that we have `Cleaner` clean up after each test, it makes sense to run this logic once in the suite, rather than after each test (which cleans up its own resources). Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
afd1e89 to
c0eb27f
Compare
dgn
approved these changes
Jun 12, 2025
Collaborator
dgn
left a comment
There was a problem hiding this comment.
Completely missed your PR introducing the Cleaner. Great Stuff, thanks @mkolesnik!
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 12, 2025
* upstream/main: Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) switch to ubi-micro (istio-ecosystem#856) Speed up docs tests by running on a single cluster (istio-ecosystem#855) Add misspell to do basic spell validation in our docs (istio-ecosystem#853)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 12, 2025
* upstream/main: Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) switch to ubi-micro (istio-ecosystem#856) Speed up docs tests by running on a single cluster (istio-ecosystem#855) Add misspell to do basic spell validation in our docs (istio-ecosystem#853)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 13, 2025
* upstream/main: Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) switch to ubi-micro (istio-ecosystem#856) Speed up docs tests by running on a single cluster (istio-ecosystem#855) Add misspell to do basic spell validation in our docs (istio-ecosystem#853)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 13, 2025
* upstream/main: Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) switch to ubi-micro (istio-ecosystem#856) Speed up docs tests by running on a single cluster (istio-ecosystem#855) Add misspell to do basic spell validation in our docs (istio-ecosystem#853)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 13, 2025
* upstream/main: Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) switch to ubi-micro (istio-ecosystem#856) Speed up docs tests by running on a single cluster (istio-ecosystem#855) Add misspell to do basic spell validation in our docs (istio-ecosystem#853)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 13, 2025
* upstream/main: (21 commits) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) switch to ubi-micro (istio-ecosystem#856) Speed up docs tests by running on a single cluster (istio-ecosystem#855) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 13, 2025
* upstream/main: (21 commits) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) switch to ubi-micro (istio-ecosystem#856) Speed up docs tests by running on a single cluster (istio-ecosystem#855) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 13, 2025
* upstream/main: (22 commits) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) switch to ubi-micro (istio-ecosystem#856) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 13, 2025
* upstream/main: (22 commits) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) switch to ubi-micro (istio-ecosystem#856) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 16, 2025
* upstream/main: (23 commits) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 16, 2025
* upstream/main: (23 commits) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 16, 2025
* upstream/main: (23 commits) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) Simplify logic when using `KEEP_ON_FAILURE` (istio-ecosystem#858) Add KEEP_ON_FAILURE flag to e2e kind tests (istio-ecosystem#832) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 16, 2025
* upstream/main: (25 commits) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) Add to vendors_default the possibility to add values for IstioCNI (istio-ecosystem#845) Updates release and nightly-images GH workflows to work with new FBC used in community-operators-prod (istio-ecosystem#854) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 16, 2025
* upstream/main: (27 commits) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 16, 2025
* upstream/main: (27 commits) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 16, 2025
* upstream/main: (27 commits) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 16, 2025
* upstream/main: (27 commits) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 17, 2025
* upstream/main: (27 commits) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 17, 2025
* upstream/main: (27 commits) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 17, 2025
* upstream/main: (27 commits) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 17, 2025
* upstream/main: (27 commits) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 18, 2025
* upstream/main: (27 commits) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 18, 2025
* upstream/main: (27 commits) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) Docs: adding istiod HA documentations (istio-ecosystem#865) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 18, 2025
* upstream/main: (28 commits) Fix docs for "broken_links" workflow (istio-ecosystem#918) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) Adding description for release workflow run (istio-ecosystem#868) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 18, 2025
* upstream/main: (29 commits) e2e allow to build and push setting target arch (istio-ecosystem#913) Fix docs for "broken_links" workflow (istio-ecosystem#918) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) Split Documentation: splitting docs, adding table of content and fixing links (istio-ecosystem#881) Do not block the workflow on errors when publishing to operatorhub.io (istio-ecosystem#877) chore(docs): cleans up IstioCNI section (istio-ecosystem#867) Force push to operator hub fork (istio-ecosystem#873) Make a yaml linter in the community-operators-prod happy (istio-ecosystem#869) ...
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jun 18, 2025
* upstream/main: (34 commits) Update VERSIONS_YAML_FILE e2e test information (istio-ecosystem#916) Improve automated docs test run (istio-ecosystem#894) Use `Eventually` in remote secret generation (istio-ecosystem#921) Docs followup link fix (istio-ecosystem#919) Fix helm issue during e2e test run operator installation (istio-ecosystem#914) e2e allow to build and push setting target arch (istio-ecosystem#913) Fix docs for "broken_links" workflow (istio-ecosystem#918) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) ...
fjglira
pushed a commit
to fjglira/sail-operator
that referenced
this pull request
Jun 19, 2025
Now that we have `Cleaner` clean up after each test, it makes sense to run this logic once in the suite, rather than after each test (which cleans up its own resources). Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
fjglira
pushed a commit
to fjglira/sail-operator
that referenced
this pull request
Jun 26, 2025
Now that we have `Cleaner` clean up after each test, it makes sense to run this logic once in the suite, rather than after each test (which cleans up its own resources). Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
istio-testing
pushed a commit
that referenced
this pull request
Jun 26, 2025
* Consolidate multicluster operator deploy/cleanup (#902) Now that we have `Cleaner` clean up after each test, it makes sense to run this logic once in the suite, rather than after each test (which cleans up its own resources). Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> * Fix typo in the ReportAfterSuite text (#911) Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> * Fix helm issue during e2e test run operator installation (#914) * Fix helm issue during e2e test run operator installation Signed-off-by: Francisco H <frherrer@redhat.com> Fix command error Signed-off-by: Francisco H <frherrer@redhat.com> * Apply suggestions from code review Co-authored-by: Mike Kolesnik <mkolesni@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Improves from code review Signed-off-by: Francisco H <frherrer@redhat.com> * Update comment in build and push script Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Mike Kolesnik <mkolesni@redhat.com> * Consolidate e2e resource creation (#931) * Consolidate IstioCNI creation in e2e tests This code is very repetitive and would better live in a common function. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> * Consolidate Istio creation in e2e tests This code is very repetitive and would better live in a common function. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> --------- Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> * Use `Eventually` in remote secret generation (#921) In this test the secret generation sometimes is attempted before everything is ready, leading to flaky, hard to debug, failures. Using `Eventually` to generate the secret avoids these failures. Fixes: #866 Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> --------- Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Mike Kolesnik <mkolesni@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
openshift-merge-bot bot
pushed a commit
to openshift-service-mesh/sail-operator
that referenced
this pull request
Jun 27, 2025
* Stabilize e2e dual-stack test (istio-ecosystem#936) (istio-ecosystem#939) Signed-off-by: Mikhail Abramov <mabramov@redhat.com> * fix IstioRevisionTag uninstall when revision namespace changes (istio-ecosystem#945) Fixes istio-ecosystem#917. This is quite a complex edge case, I'll do my best to explain. If you look at the integration test I wrote (part of this commit), you can follow along. When a tag was created that referenced a revision in ns1, then patched to reference a revision in ns2, we failed to clean up the old helm install in ns1. That almost never causes problems - except in the case where afterwards, you remove all tags, and then create a new one with the same name that is never reconciled. If that tag is deleted, the operator will attempt to uninstall that lingering helm release, which fails, leading the operator to deadlock, and stopping the user from deleting the tag. The only way to get the operator back into a working state would be to manually delete that lingering helm release. That is a pretty significant bug in my opinion. Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com> * Expose "Profile" parameter in UI for Istio and IstioCNI (istio-ecosystem#924) (istio-ecosystem#947) During deployment of Istio in ambient mode, the user should be able to set the "profile: ambient" for Istio and IstioCNI resources. Currently, this parameter is hidden from the UI. Turn on the visibility of this parameter in the UI. Signed-off-by: Maxim Babushkin <mbabushk@redhat.com> * [Manual Cherry pick] Pick e2e improve and solving helm issues (istio-ecosystem#948) * Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Now that we have `Cleaner` clean up after each test, it makes sense to run this logic once in the suite, rather than after each test (which cleans up its own resources). Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> * Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> * Fix helm issue during e2e test run operator installation (istio-ecosystem#914) * Fix helm issue during e2e test run operator installation Signed-off-by: Francisco H <frherrer@redhat.com> Fix command error Signed-off-by: Francisco H <frherrer@redhat.com> * Apply suggestions from code review Co-authored-by: Mike Kolesnik <mkolesni@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Improves from code review Signed-off-by: Francisco H <frherrer@redhat.com> * Update comment in build and push script Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Mike Kolesnik <mkolesni@redhat.com> * Consolidate e2e resource creation (istio-ecosystem#931) * Consolidate IstioCNI creation in e2e tests This code is very repetitive and would better live in a common function. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> * Consolidate Istio creation in e2e tests This code is very repetitive and would better live in a common function. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> --------- Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> * Use `Eventually` in remote secret generation (istio-ecosystem#921) In this test the secret generation sometimes is attempted before everything is ready, leading to flaky, hard to debug, failures. Using `Eventually` to generate the secret avoids these failures. Fixes: istio-ecosystem#866 Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> --------- Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Mike Kolesnik <mkolesni@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> * Bump to 1.26.2, add Istio 1.26.2 (istio-ecosystem#950) Signed-off-by: Daniel Grimm <dgrimm@redhat.com> --------- Signed-off-by: Mikhail Abramov <mabramov@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Maxim Babushkin <mbabushk@redhat.com> Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Mikhail Abramov <mabramov@redhat.com> Co-authored-by: Istio Automation <istio-testing-bot@google.com> Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Maxim Babushkin <mbabushk@redhat.com> Co-authored-by: Francisco Herrera <frherrer@redhat.com> Co-authored-by: Mike Kolesnik <mkolesni@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
dgn
pushed a commit
to dgn/sail-operator
that referenced
this pull request
Mar 17, 2026
Now that we have `Cleaner` clean up after each test, it makes sense to run this logic once in the suite, rather than after each test (which cleans up its own resources). Signed-off-by: Mike Kolesnik <mkolesni@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have
Cleanerclean up after each test, it makes sense to run this logic once in the suite, rather than after each test (which cleans up its own resources).What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Related Issue/PR #666
Additional information: