Skip to content

Fix helm issue during e2e test run operator installation#914

Merged
istio-testing merged 4 commits intoistio-ecosystem:mainfrom
fjglira:fix-helm-name-issue
Jun 18, 2025
Merged

Fix helm issue during e2e test run operator installation#914
istio-testing merged 4 commits intoistio-ecosystem:mainfrom
fjglira:fix-helm-name-issue

Conversation

@fjglira
Copy link
Copy Markdown
Contributor

@fjglira fjglira commented Jun 16, 2025

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

The operator namespace was being created during the image build/push only for OCP test runs, leading to a 'helm name error' in subsequent tests case. This happened because the cleaner record was incorrectly preventing the deletion of the sail-operator namespace.

Adding also the rollback of #907

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

@fjglira fjglira requested a review from a team as a code owner June 16, 2025 16:26
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.93%. Comparing base (72035af) to head (6f0c505).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #914   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files          44       44           
  Lines        2679     2679           
=======================================
  Hits         2061     2061           
  Misses        524      524           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fjglira fjglira force-pushed the fix-helm-name-issue branch from 76b736f to e28405e Compare June 16, 2025 16:44
# We create the operator namespace before the tests run
# To avoid any cleanup issues, after we build annd push the image we check if the namespace exists and delete it if it does.
# The test logic already handle the namespace creation and deletion during the test run.
# TODO: remove hardcoded kubectl command and use the COMMAND variable instead. To be changed during OCP enable doc test.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be pending until we make some changes to the run-docs-examples.sh script to enable the possibility to run the docs test over OCP clusters. To not mixing changes, meanwhile, I hardcoded kubectl.

Copy link
Copy Markdown

@cansintartici cansintartici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Collaborator

@mkolesnik mkolesnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of typos.

Also I'm not sure I understand why this needs to be specifically in the build-and-push-operator script and not, for example, the scripts that actually run the tests?
e.g. integ-suite-ocp.sh

@fjglira
Copy link
Copy Markdown
Contributor Author

fjglira commented Jun 17, 2025

Couple of typos.

Also I'm not sure I understand why this needs to be specifically in the build-and-push-operator script and not, for example, the scripts that actually run the tests? e.g. integ-suite-ocp.sh

I'll move it as a validation step inside to the script that actually run the test

fjglira and others added 2 commits June 17, 2025 13:49
Signed-off-by: Francisco H <frherrer@redhat.com>

Fix command error

Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>
@fjglira
Copy link
Copy Markdown
Contributor Author

fjglira commented Jun 17, 2025

Couple of typos.

Also I'm not sure I understand why this needs to be specifically in the build-and-push-operator script and not, for example, the scripts that actually run the tests? e.g. integ-suite-ocp.sh

Hey, I did some changes:

  • Create a new namespace to push the operator image. This will avoid any issues while deleting the operator namespace. Fun fact, this was working before because once we pulled the first time the image from the operator namespace, it was in cache, no matter that we deleted and created again the operator namespace (Started to fail to me today after I started to delete the operator namespace before starting the test)
  • Set the proper roles for the new namespace and the operator namespace to be able to pull and push the image
  • Moved the deletion of the operator namespace to the common script that actually runs the test after validating that we are running for OCP. Note: we still need to create the operator namespace to create the roles to pull the image

@fjglira fjglira requested a review from mkolesnik June 17, 2025 16:09

# Workaround for OCP helm operator installation issues:
# To avoid any cleanup issues, after we build and push the image we check if the namespace exists and delete it if it does.
# The test logic already handles the namespace creation and deletion during the test run.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's done by tests, why it's needed also here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few weeks ago, we introduced a new cleanup method to ensure that all resources are cleaned up after each test run. This involves recording all resources before and after the test. because at the start of the first test, the sail operator namespace already exists from the setup, it's not being deleted at the end of the test, and this causes an error because the helm release still exists in the cluster and gives us a helm can't use any in-use name

URL=$(${COMMAND} get route default-route -n openshift-image-registry --template='{{ .spec.host }}')
export HUB="${URL}/${NAMESPACE}"

# Create the istio-images namespace to store the operator image and avoid errors during test run.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which errors is this avoiding?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rephrase this comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: Francisco H <frherrer@redhat.com>
@fjglira
Copy link
Copy Markdown
Contributor Author

fjglira commented Jun 18, 2025

/test e2e-kind-multicluster

@istio-testing istio-testing merged commit 5fc8365 into istio-ecosystem:main Jun 18, 2025
16 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Jun 18, 2025
* upstream/main: (34 commits)
  Update VERSIONS_YAML_FILE e2e test information (istio-ecosystem#916)
  Improve automated docs test run (istio-ecosystem#894)
  Use `Eventually` in remote secret generation (istio-ecosystem#921)
  Docs followup link fix (istio-ecosystem#919)
  Fix helm issue during e2e test run  operator installation (istio-ecosystem#914)
  e2e allow to build and push setting target arch (istio-ecosystem#913)
  Fix docs for "broken_links" workflow (istio-ecosystem#918)
  Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905)
  Fix typo in the ReportAfterSuite text (istio-ecosystem#911)
  Fix cleanup in multicluster tests (istio-ecosystem#909)
  Adding Eventually to Helm operator install (istio-ecosystem#907)
  Skip cleanup if control plane tests fail (istio-ecosystem#910)
  Use debug logging in integration tests (istio-ecosystem#906)
  Annotate only our clusters when using kind (istio-ecosystem#904)
  Fix log message for cleaner when waiting (istio-ecosystem#903)
  Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)
  Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889)
  Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891)
  Update github action for broken links (istio-ecosystem#888)
  Fix "Check broken link" workflow (istio-ecosystem#887)
  ...
@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: #914 failed to apply on top of branch "release-1.26":

Applying: Fix helm issue during e2e test run operator installation
.git/rebase-apply/patch:105: trailing whitespace.
# The test logic already handle the namespace creation and deletion during the test run. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	tests/e2e/ambient/ambient_test.go
M	tests/e2e/controlplane/control_plane_suite_test.go
M	tests/e2e/dualstack/dualstack_test.go
M	tests/e2e/multicluster/multicluster_suite_test.go
M	tests/e2e/multicontrolplane/multi_control_plane_test.go
M	tests/e2e/operator/operator_install_test.go
M	tests/e2e/setup/build-and-push-operator.sh
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/setup/build-and-push-operator.sh
Auto-merging tests/e2e/multicluster/multicluster_suite_test.go
CONFLICT (content): Merge conflict in tests/e2e/multicluster/multicluster_suite_test.go
Auto-merging tests/e2e/controlplane/control_plane_suite_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix helm issue during e2e test run operator installation

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new issue created for failed cherrypick: #935

fjglira added a commit to fjglira/sail-operator that referenced this pull request Jun 19, 2025
…stem#914)

* Fix helm issue during e2e test run  operator installation

Signed-off-by: Francisco H <frherrer@redhat.com>

Fix command error

Signed-off-by: Francisco H <frherrer@redhat.com>

* Apply suggestions from code review

Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>

* Improves from code review

Signed-off-by: Francisco H <frherrer@redhat.com>

* Update comment in build and push script

Signed-off-by: Francisco H <frherrer@redhat.com>

---------

Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
fjglira added a commit to fjglira/sail-operator that referenced this pull request Jun 26, 2025
…stem#914)

* Fix helm issue during e2e test run  operator installation

Signed-off-by: Francisco H <frherrer@redhat.com>

Fix command error

Signed-off-by: Francisco H <frherrer@redhat.com>

* Apply suggestions from code review

Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>

* Improves from code review

Signed-off-by: Francisco H <frherrer@redhat.com>

* Update comment in build and push script

Signed-off-by: Francisco H <frherrer@redhat.com>

---------

Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
istio-testing pushed a commit that referenced this pull request Jun 26, 2025
* Consolidate multicluster operator deploy/cleanup (#902)

Now that we have `Cleaner` clean up after each test, it makes sense to
run this logic once in the suite, rather than after each test (which
cleans up its own resources).

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

* Fix typo in the ReportAfterSuite text (#911)

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

* Fix helm issue during e2e test run  operator installation (#914)

* Fix helm issue during e2e test run  operator installation

Signed-off-by: Francisco H <frherrer@redhat.com>

Fix command error

Signed-off-by: Francisco H <frherrer@redhat.com>

* Apply suggestions from code review

Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>

* Improves from code review

Signed-off-by: Francisco H <frherrer@redhat.com>

* Update comment in build and push script

Signed-off-by: Francisco H <frherrer@redhat.com>

---------

Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>

* Consolidate e2e resource creation (#931)

* Consolidate IstioCNI creation in e2e tests

This code is very repetitive and would better live in a common function.

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

* Consolidate Istio creation in e2e tests

This code is very repetitive and would better live in a common function.

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

---------

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

* Use `Eventually` in remote secret generation (#921)

In this test the secret generation sometimes is attempted before
everything is ready, leading to flaky, hard to debug, failures.

Using `Eventually` to generate the secret avoids these failures.

Fixes: #866

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

---------

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
openshift-merge-bot bot pushed a commit to openshift-service-mesh/sail-operator that referenced this pull request Jun 27, 2025
* Stabilize e2e dual-stack test (istio-ecosystem#936) (istio-ecosystem#939)

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>

* fix IstioRevisionTag uninstall when revision namespace changes (istio-ecosystem#945)

Fixes istio-ecosystem#917.

This is quite a complex edge case, I'll do my best to explain. If you
look at the integration test I wrote (part of this commit), you can
follow along.

When a tag was created that referenced a revision in ns1, then patched
to reference a revision in ns2, we failed to clean up the old helm
install in ns1. That almost never causes problems - except in the case
where afterwards, you remove all tags, and then create a new one with
the same name that is never reconciled. If that tag is deleted, the operator will
attempt to uninstall that lingering helm release, which fails, leading
the operator to deadlock, and stopping the user from deleting the tag.
The only way to get the operator back into a working state would be to
manually delete that lingering helm release. That is a pretty
significant bug in my opinion.

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Co-authored-by: Daniel Grimm <dgrimm@redhat.com>

* Expose "Profile" parameter in UI for Istio and IstioCNI (istio-ecosystem#924) (istio-ecosystem#947)

During deployment of Istio in ambient mode, the user should be able to
set the "profile: ambient" for Istio and IstioCNI resources.
Currently, this parameter is hidden from the UI.
Turn on the visibility of this parameter in the UI.

Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>

* [Manual Cherry pick] Pick e2e improve and solving helm issues (istio-ecosystem#948)

* Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902)

Now that we have `Cleaner` clean up after each test, it makes sense to
run this logic once in the suite, rather than after each test (which
cleans up its own resources).

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

* Fix typo in the ReportAfterSuite text (istio-ecosystem#911)

Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

* Fix helm issue during e2e test run  operator installation (istio-ecosystem#914)

* Fix helm issue during e2e test run  operator installation

Signed-off-by: Francisco H <frherrer@redhat.com>

Fix command error

Signed-off-by: Francisco H <frherrer@redhat.com>

* Apply suggestions from code review

Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>

* Improves from code review

Signed-off-by: Francisco H <frherrer@redhat.com>

* Update comment in build and push script

Signed-off-by: Francisco H <frherrer@redhat.com>

---------

Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>

* Consolidate e2e resource creation (istio-ecosystem#931)

* Consolidate IstioCNI creation in e2e tests

This code is very repetitive and would better live in a common function.

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

* Consolidate Istio creation in e2e tests

This code is very repetitive and would better live in a common function.

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

---------

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

* Use `Eventually` in remote secret generation (istio-ecosystem#921)

In this test the secret generation sometimes is attempted before
everything is ready, leading to flaky, hard to debug, failures.

Using `Eventually` to generate the secret avoids these failures.

Fixes: istio-ecosystem#866

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

---------

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>

* Bump to 1.26.2, add Istio 1.26.2 (istio-ecosystem#950)

Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

---------

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>
Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mikhail Abramov <mabramov@redhat.com>
Co-authored-by: Istio Automation <istio-testing-bot@google.com>
Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
Co-authored-by: Maxim Babushkin <mbabushk@redhat.com>
Co-authored-by: Francisco Herrera <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
mkolesnik added a commit to mkolesnik/sail-operator that referenced this pull request Jul 7, 2025
…stem#914)

* Fix helm issue during e2e test run  operator installation

Signed-off-by: Francisco H <frherrer@redhat.com>

Fix command error

Signed-off-by: Francisco H <frherrer@redhat.com>

* Apply suggestions from code review

Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>

* Improves from code review

Signed-off-by: Francisco H <frherrer@redhat.com>

* Update comment in build and push script

Signed-off-by: Francisco H <frherrer@redhat.com>

---------

Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
(cherry picked from commit 5fc8365)
@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: #914 failed to apply on top of branch "release-1.26":

Applying: Fix helm issue during e2e test run operator installation
.git/rebase-apply/patch:105: trailing whitespace.
# The test logic already handle the namespace creation and deletion during the test run. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	tests/e2e/ambient/ambient_test.go
M	tests/e2e/dualstack/dualstack_test.go
M	tests/e2e/multicluster/multicluster_suite_test.go
M	tests/e2e/multicontrolplane/multi_control_plane_test.go
M	tests/e2e/setup/build-and-push-operator.sh
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/setup/build-and-push-operator.sh
CONFLICT (content): Merge conflict in tests/e2e/setup/build-and-push-operator.sh
Auto-merging tests/e2e/multicontrolplane/multi_control_plane_test.go
Auto-merging tests/e2e/multicluster/multicluster_suite_test.go
Auto-merging tests/e2e/dualstack/dualstack_test.go
Auto-merging tests/e2e/ambient/ambient_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Fix helm issue during e2e test run operator installation

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new issue created for failed cherrypick: #987

mkolesnik added a commit to mkolesnik/sail-operator that referenced this pull request Jul 7, 2025
…stem#914)

* Fix helm issue during e2e test run  operator installation

Signed-off-by: Francisco H <frherrer@redhat.com>

Fix command error

Signed-off-by: Francisco H <frherrer@redhat.com>

* Apply suggestions from code review

Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>

* Improves from code review

Signed-off-by: Francisco H <frherrer@redhat.com>

* Update comment in build and push script

Signed-off-by: Francisco H <frherrer@redhat.com>

---------
(cherry picked from commit 5fc8365)

Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
mkolesnik added a commit to mkolesnik/sail-operator that referenced this pull request Jul 7, 2025
…stem#914)

* Fix helm issue during e2e test run  operator installation

Signed-off-by: Francisco H <frherrer@redhat.com>

Fix command error

Signed-off-by: Francisco H <frherrer@redhat.com>

* Apply suggestions from code review

Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>

* Improves from code review

Signed-off-by: Francisco H <frherrer@redhat.com>

* Update comment in build and push script

Signed-off-by: Francisco H <frherrer@redhat.com>

---------
(cherry picked from commit 5fc8365)

Signed-off-by: Francisco Herrera <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
istio-testing pushed a commit that referenced this pull request Jul 7, 2025
* Fix helm issue during e2e test run  operator installation (#914)

* Fix helm issue during e2e test run  operator installation

Signed-off-by: Francisco H <frherrer@redhat.com>

Fix command error

Signed-off-by: Francisco H <frherrer@redhat.com>

* Apply suggestions from code review

Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>

* Improves from code review

Signed-off-by: Francisco H <frherrer@redhat.com>

* Update comment in build and push script

Signed-off-by: Francisco H <frherrer@redhat.com>

---------
(cherry picked from commit 5fc8365)

Signed-off-by: Francisco Herrera <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>

* Deploy operator in the E2E scripts

Given that we have the `Cleaner` and each test should be cleaning after
itself, deploying the operator just once per test run will save some
test run time.
An added value is the tests are simplified and can focus on what they
need to achieve, instead of bothering with the operator setup.

Fixes: #666
(cherry picked from commit 4434ddf)

Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

---------

Signed-off-by: Francisco Herrera <frherrer@redhat.com>
Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
Co-authored-by: Francisco Herrera <frherrer@redhat.com>
dgn pushed a commit to dgn/sail-operator that referenced this pull request Mar 17, 2026
…stem#914)

* Fix helm issue during e2e test run  operator installation

Signed-off-by: Francisco H <frherrer@redhat.com>

Fix command error

Signed-off-by: Francisco H <frherrer@redhat.com>

* Apply suggestions from code review

Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>

* Improves from code review

Signed-off-by: Francisco H <frherrer@redhat.com>

* Update comment in build and push script

Signed-off-by: Francisco H <frherrer@redhat.com>

---------

Signed-off-by: Francisco H <frherrer@redhat.com>
Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants