Skip to content

Fix ztunnel controller to apply values.ztunnel config#568

Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
sridhargaddam:issue-567
Jan 23, 2025
Merged

Fix ztunnel controller to apply values.ztunnel config#568
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
sridhargaddam:issue-567

Conversation

@sridhargaddam
Copy link
Copy Markdown
Contributor

In the Sail Operator, any config specified under values.ztunnel in the ZTunnel resource was being ignored. This fix ensures that the ztunnel controller correctly applies these values.

Fixes: #567

In the Sail Operator, any config specified under values.ztunnel
in the ZTunnel resource was being ignored. This fix ensures that
the ztunnel controller correctly applies these values.

Fixes: istio-ecosystem#567
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@dgn
Copy link
Copy Markdown
Collaborator

dgn commented Jan 21, 2025

/cherry-pick release-1.0

@istio-testing
Copy link
Copy Markdown
Collaborator

@dgn: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.74%. Comparing base (e27e1be) to head (fc16652).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
pkg/istiovalues/profiles.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   75.65%   70.74%   -4.92%     
==========================================
  Files          40       34       -6     
  Lines        2481     1979     -502     
==========================================
- Hits         1877     1400     -477     
+ Misses        514      466      -48     
- Partials       90      113      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sridhargaddam
Copy link
Copy Markdown
Contributor Author

@dgn @luksa PTAL, thanks.

@sridhargaddam sridhargaddam requested review from dgn and luksa January 22, 2025 17:52
@dgn
Copy link
Copy Markdown
Collaborator

dgn commented Jan 23, 2025

/retest

@istio-testing istio-testing merged commit 6f59106 into istio-ecosystem:main Jan 23, 2025
@istio-testing
Copy link
Copy Markdown
Collaborator

@dgn: new pull request created: #580

Details

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Jan 23, 2025
* upstream/main:
  Fix ztunnel controller to apply values.ztunnel config (openshift-service-mesh#568)
FilipB added a commit to FilipB/sail-operator that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Configuration in ZTunnelConfig is Ignored while deploying ambient

4 participants