[release-1.0] Disable imageDigest support in ztunnel controller#596
Merged
istio-testing merged 2 commits intoistio-ecosystem:release-1.0from Jan 30, 2025
Merged
Conversation
Currently, we have some pending work with the ztunnel images that are used as imageDigests. Because of this, when deploying Ambient profile using the OSSM operator, the ztunnel pod fails to come up. This PR temporarily disables this functionality until proper support is implemented. Alternatives: 1. Default Image: If no image details are provided in the ZTunnel CR, the operator will use the default image from the helm chart. 2. Explicitly specify image details: Following a recent fix in the ztunnel controller (PR#568), users can specify image details within the ztunnel CR itself in one of the following ways. 2.1: ztunnel.spec.values.ztunnel.image 2.2: ztunnel.spec.values.global.hub/tag Fixes: istio-ecosystem#581 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.0 #596 +/- ##
===============================================
- Coverage 75.10% 74.48% -0.62%
===============================================
Files 40 40
Lines 2498 2504 +6
===============================================
- Hits 1876 1865 -11
- Misses 531 550 +19
+ Partials 91 89 -2 ☔ View full report in Codecov by Sentry. |
sridhargaddam
approved these changes
Jan 30, 2025
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Feb 3, 2025
* upstream/release-1.0: [release-1.0] Fix sailoperator v1 api-docs (openshift-service-mesh#593) Helm: Remove redundant platform-specific cmd during installation (openshift-service-mesh#607) Update ztunnel comment in api_transformer (openshift-service-mesh#603) [release-1.0] Add an Ambient mode documentation (openshift-service-mesh#600) Fix ztunnel controller to apply values.ztunnel config (openshift-service-mesh#580) [release-1.0] link ambient doc in the doc/table of contents (openshift-service-mesh#601) [release-1.0] Disable imageDigest support in ztunnel controller (openshift-service-mesh#596) [release-1.0] Use logAsJson instead of logAsJSON in ZTunnel APIs (openshift-service-mesh#594)
FilipB
pushed a commit
to FilipB/sail-operator
that referenced
this pull request
Dec 1, 2025
* upstream/main: move common functions under util/common (istio-ecosystem#1189) Signed-off-by: Mikhail Abramov <mabramov@redhat.com> Co-authored-by: openshift-service-mesh-bot <null>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #582