Skip to content

Fix new lint errors#1233

Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
fjglira:fix-lint
Sep 25, 2025
Merged

Fix new lint errors#1233
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
fjglira:fix-lint

Conversation

@fjglira
Copy link
Copy Markdown
Contributor

@fjglira fjglira commented Sep 25, 2025

Fix lint errors that are happening in the PR: #1231

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

Fix lint error that are happening in the PR: 1231

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
@fjglira fjglira requested a review from a team as a code owner September 25, 2025 14:57
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.39%. Comparing base (e823206) to head (7484541).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
controllers/istio/istio_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   77.50%   77.39%   -0.11%     
==========================================
  Files          44       44              
  Lines        2823     2823              
==========================================
- Hits         2188     2185       -3     
- Misses        527      529       +2     
- Partials      108      109       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}

return
return result, err
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was present since couple of months. Did the linter config change recently?

@istio-testing istio-testing merged commit 8958564 into istio-ecosystem:main Sep 25, 2025
15 of 17 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 25, 2025
* upstream/main:
  Fix broken link to docs/readme (istio-ecosystem#1231)
  Fix new lint errors (istio-ecosystem#1233)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 26, 2025
* upstream/main:
  Fix broken link to docs/readme (istio-ecosystem#1231)
  Fix new lint errors (istio-ecosystem#1233)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 26, 2025
* upstream/main:
  Fix broken link to docs/readme (istio-ecosystem#1231)
  Fix new lint errors (istio-ecosystem#1233)
@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request created: #1234

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio-ecosystem/sail-operator#release-1.26 from head istio-testing:cherry-pick-1233-to-release-1.26: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-1233-to-release-1.26."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request created: #1235

@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio-ecosystem/sail-operator#release-1.27 from head istio-testing:cherry-pick-1233-to-release-1.27: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-1233-to-release-1.27."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 26, 2025
* upstream/main:
  Fix broken link to docs/readme (istio-ecosystem#1231)
  Fix new lint errors (istio-ecosystem#1233)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 26, 2025
* upstream/main:
  fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236)
  Fix broken link to docs/readme (istio-ecosystem#1231)
  Fix new lint errors (istio-ecosystem#1233)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request Sep 29, 2025
* upstream/main:
  fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236)
  Fix broken link to docs/readme (istio-ecosystem#1231)
  Fix new lint errors (istio-ecosystem#1233)
dgn pushed a commit to dgn/sail-operator that referenced this pull request Mar 17, 2026
Fix lint error that are happening in the PR: 1231

Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants