Fix new lint errors#1233
Conversation
Fix lint error that are happening in the PR: 1231 Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1233 +/- ##
==========================================
- Coverage 77.50% 77.39% -0.11%
==========================================
Files 44 44
Lines 2823 2823
==========================================
- Hits 2188 2185 -3
- Misses 527 529 +2
- Partials 108 109 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| return | ||
| return result, err |
There was a problem hiding this comment.
Looks like this was present since couple of months. Did the linter config change recently?
* upstream/main: Fix broken link to docs/readme (istio-ecosystem#1231) Fix new lint errors (istio-ecosystem#1233)
* upstream/main: Fix broken link to docs/readme (istio-ecosystem#1231) Fix new lint errors (istio-ecosystem#1233)
* upstream/main: Fix broken link to docs/readme (istio-ecosystem#1231) Fix new lint errors (istio-ecosystem#1233)
|
In response to a cherrypick label: new pull request created: #1234 |
|
In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio-ecosystem/sail-operator#release-1.26 from head istio-testing:cherry-pick-1233-to-release-1.26: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-1233-to-release-1.26."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} |
|
In response to a cherrypick label: new pull request created: #1235 |
|
In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio-ecosystem/sail-operator#release-1.27 from head istio-testing:cherry-pick-1233-to-release-1.27: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-1233-to-release-1.27."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} |
* upstream/main: Fix broken link to docs/readme (istio-ecosystem#1231) Fix new lint errors (istio-ecosystem#1233)
* upstream/main: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) Fix broken link to docs/readme (istio-ecosystem#1231) Fix new lint errors (istio-ecosystem#1233)
* upstream/main: fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) Fix broken link to docs/readme (istio-ecosystem#1231) Fix new lint errors (istio-ecosystem#1233)
Fix lint error that are happening in the PR: 1231 Signed-off-by: Francisco Herrera <fjglira@gmail.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Fix lint errors that are happening in the PR: #1231
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Related Issue/PR #
Additional information: