feat: Upgrade bootstrap to 5.3.0 and enable dark mode #5509

larseggert · 2023-04-19T20:22:18Z

codecov · 2023-04-25T17:57:24Z

Codecov Report

❗ No coverage uploaded for pull request base (feat/dark-mode@1ec403d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 685a20f differs from pull request most recent head 7497143. Consider uploading reports for the commit 7497143 to get more accurate results

@@                Coverage Diff                @@
##             feat/dark-mode    #5509   +/-   ##
=================================================
  Coverage                  ?   88.74%           
=================================================
  Files                     ?      285           
  Lines                     ?    39853           
  Branches                  ?        0           
=================================================
  Hits                      ?    35366           
  Misses                    ?     4487           
  Partials                  ?        0

Try again with Django 3.2

Patch no longer applies. Needed until Django 4.2.1, so bring it back if we deploy something earlier than that to production.

This reverts commit 2cf2a3d.

…elForm

Relying on Meta.ordering to order querysets involving GROUP BY queries is deprecated and will be dropped in Django 3.1.

Not sure why, but if I change the DeprecationWarning filter to "error", I get a SyntaxError from the \[ because it is an invalid escape sequence. Not sure why that change triggers it, but "\[" and "\\[" are the same, so this is a no-op.

chore: Upgrade to Django 3.0

chore: merge main into feat/django4

* test: Remove ScheduleEditTests.testUnschedule Has been disabled under Django 2. Simple refactoring does not make it functional under Django 3. Probably because we know that Selenium does not handle HTML5 drag-and-drop well. Discarding until we move to a better JS testing framework. * test: Remove unused imports

…ls#5726) * fix: Return NomComs, not Groups, from active_nomcoms filter * fix: deduplicate and order nomcoms in active_nomcoms filter

larseggert · 2023-06-01T08:27:22Z

* The IETF logo on the homepage should vary to light text when in dark mode.

I made that change (also to other logos).

* The agenda page isn't adapted for dark mode (I'll contribute to this PR to add the missing bits)

Thanks!

* Might be best to add a button in the header or footer to quickly switch between light and dark mode. Not everyone will know to look in Preferences.

Maybe. It'd make it pretty busy.

When first loading the site, not logged in, it was automatically set to "Dark" instead of "Auto"?

Odd. Do you maybe have previous data in localstorage? I just tried in private browsing mode and it comes up in "auto".

…-tools#5728)

…etf-tools#5730) * fix: Accept a Path as source for a PlaintextDraft * fix: Guard against failure to extract PlaintextDraft title * fix: Ignore failure to extract text draft title unless it is needed

* fix: Extract document creation date from XML draft * test: Fix test

Merge pull request ietf-tools#5698 from ietf-tools/main

…f-tools#5735)

chore: Merge main into feat/django4

chore: Use permissive cross-origin-opener-policy setting

feat!: django4

Fixes ietf-tools#3365

NGPixel force-pushed the feat-dark-mode branch from 7a18bfc to bc4097c Compare April 25, 2023 17:14

jennifer-richards added 28 commits May 8, 2023 15:03

chore: Update requirements.txt for Django 3.0

e1b783e

fix: Replace available_attrs helper (dropped by Django 3.0)

9fda268

fix: Replace obsolete curry() with functools.partialmethod()

6d4d095

chore: Revert psycopg2 dependency

9fde845

Try again with Django 3.2

chore: Remove django-cookie-delete-with-all-settings.patch

2cf2a3d

Patch no longer applies. Needed until Django 4.2.1, so bring it back if we deploy something earlier than that to production.

Merge remote-tracking branch 'origin/main' into django4

dcb211f

refactor: Replace deprecated force_text with force_str

07e26dd

refactor: Replace deprecated smart_text with smart_str

da16839

chore: Tweak add-django-http-cookie-value-none.patch for Django 3.0

31fd431

chore: Rename DB engine to drop the deprecated "_psycopg2" suffix

ed571ae

test: Do not misuse django.conf.settings for HTML validation params

69eb634

Revert "chore: Remove django-cookie-delete-with-all-settings.patch"

57026bb

This reverts commit 2cf2a3d.

chore: Fix cookie-delete patch to work with Django 3.0

21ac8c0

chore: Remove accidentally reverted removal of form_utils app

a75dbd4

refactor: Refactor LiaisonForm without BetterModelForm

85d0934

refactor: Replace obsolete staticfiles template lib with static

163479b

refactor: Explicitly allow name=None for a couple of views

4f443cc

fix: Finish refactoring LiaisonModelForm subclasses without BetterMod…

1015cf8

…elForm

chore: Remove filter on staticfiles DeprecationWarning

e6259a5

style: Apply Black style to active_group_types() view

406ba7b

fix: Explicitly order GroupTypeNames in active_group_types

eee145e

Relying on Meta.ordering to order querysets involving GROUP BY queries is deprecated and will be dropped in Django 3.1.

style: Double backslashes in strings

0d07059

Not sure why, but if I change the DeprecationWarning filter to "error", I get a SyntaxError from the \[ because it is an invalid escape sequence. Not sure why that change triggers it, but "\[" and "\\[" are the same, so this is a no-op.

chore: Merge main into feat/django4

477a2de

Merge pull request ietf-tools#5601 from jennifer-richards/django4

264ff60

chore: Upgrade to Django 3.0

ci: run tests on feat/django4 PRs (ietf-tools#5604)

f8a9efc

Merge pull request ietf-tools#5611 from ietf-tools/main

96396b8

chore: merge main into feat/django4

chore: Update requirements.txt for Django 3.1

b2534fd

fix: Return NomComs, not Groups, from active_nomcoms filter (ietf-too…

3391166

…ls#5726) * fix: Return NomComs, not Groups, from active_nomcoms filter * fix: deduplicate and order nomcoms in active_nomcoms filter

rjsparks and others added 24 commits June 1, 2023 09:32

fix: explain what is not counted in the meeting request summary (ietf…

36b847b

…-tools#5728)

fix: Ignore failure to extract text draft title unless it is needed (i…

8d4780d

…etf-tools#5730) * fix: Accept a Path as source for a PlaintextDraft * fix: Guard against failure to extract PlaintextDraft title * fix: Ignore failure to extract text draft title unless it is needed

feat: Extract document creation date from XML draft (ietf-tools#5733)

5a27082

* fix: Extract document creation date from XML draft * test: Fix test

fix: use @fullcalendar/luxon3 plugin (ietf-tools#5729)

a9833d5

Merge pull request ietf-tools#5736 from ietf-tools/release

c5b75d3

Merge pull request ietf-tools#5698 from ietf-tools/main

feat: Use distinct event desc for drafts received via api_submit (iet…

e3d16bc

…f-tools#5735)

chore: Use permissive cross-origin-opener-policy setting

2d661a1

Merge pull request ietf-tools#5738 from ietf-tools/main

c8f9739

chore: Merge main into feat/django4

Merge pull request ietf-tools#5739 from jennifer-richards/coop_setting

5d467d9

chore: Use permissive cross-origin-opener-policy setting

Merge pull request ietf-tools#5740 from ietf-tools/feat/django4

f711c83

feat!: django4

feat: Upgrade bootstrap to 5.3.0 and enable dark mode

b3c7094

Fixes ietf-tools#3365

Enable dark mode in other views

df1a4bf

Fix some colors

54c7951

Fix more colors

e6f351b

feat: Upgrade bootstrap to 5.3.0 and enable dark mode

93d50f9

Fixes ietf-tools#3365

Enable dark mode in other views

112d3b9

Color mode fixes

342e6f5

Fix switching in HTMLized view

f850061

Load theme.js in header, to avoid flickering

e5163b6

Fix some badges

8caf3a7

[email protected]

6f8a798

Address review comments

27f9e6a

Fix title

e6f47a0

Better select2 fix

7497143

larseggert force-pushed the feat-dark-mode branch from 0c92ef8 to 7497143 Compare June 2, 2023 08:46

rjsparks merged commit ce3114c into ietf-tools:feat/dark-mode Jun 13, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023

larseggert deleted the feat-dark-mode branch August 10, 2023 15:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Upgrade bootstrap to 5.3.0 and enable dark mode #5509

feat: Upgrade bootstrap to 5.3.0 and enable dark mode #5509

larseggert commented Apr 19, 2023

codecov bot commented Apr 25, 2023 •

edited

Loading

larseggert commented Jun 1, 2023

feat: Upgrade bootstrap to 5.3.0 and enable dark mode #5509

feat: Upgrade bootstrap to 5.3.0 and enable dark mode #5509

Conversation

larseggert commented Apr 19, 2023

codecov bot commented Apr 25, 2023 • edited Loading

Codecov Report

larseggert commented Jun 1, 2023

codecov bot commented Apr 25, 2023 •

edited

Loading