Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore failure to extract text draft title unless it is needed #5730

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

jennifer-richards
Copy link
Member

Fixes a few problems related to the async submission refactoring.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #5730 (bf3229b) into main (d595aac) will increase coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head bf3229b differs from pull request most recent head 3f4db0d. Consider uploading reports for the commit 3f4db0d to get more accurate results

@@           Coverage Diff           @@
##             main    #5730   +/-   ##
=======================================
  Coverage   88.73%   88.73%           
=======================================
  Files         285      285           
  Lines       39852    39852           
=======================================
+ Hits        35362    35363    +1     
+ Misses       4490     4489    -1     
Impacted Files Coverage Δ
ietf/submit/utils.py 90.17% <80.00%> (+0.02%) ⬆️
ietf/utils/draft.py 73.19% <100.00%> (-0.11%) ⬇️

... and 6 files with indirect coverage changes

@rjsparks rjsparks merged commit 8d4780d into ietf-tools:main Jun 1, 2023
@jennifer-richards jennifer-richards deleted the text-title-not-required branch June 1, 2023 14:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants