Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return NomComs, not Groups, from active_nomcoms filter #5726

Merged
merged 2 commits into from
May 31, 2023

Conversation

jennifer-richards
Copy link
Member

Fixes #5723

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #5726 (30e781c) into main (d595aac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5726   +/-   ##
=======================================
  Coverage   88.73%   88.74%           
=======================================
  Files         285      285           
  Lines       39852    39850    -2     
=======================================
+ Hits        35362    35363    +1     
+ Misses       4490     4487    -3     
Impacted Files Coverage Δ
ietf/group/templatetags/group_filters.py 91.30% <100.00%> (-0.70%) ⬇️

... and 3 files with indirect coverage changes

@rjsparks rjsparks merged commit 3391166 into ietf-tools:main May 31, 2023
@jennifer-richards jennifer-richards deleted the nomcom-filter branch June 1, 2023 14:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't crash when a nomcom is partially set up.
2 participants