chore: Upgrade to Django 3.0 #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try again with Django 3.2
Patch no longer applies. Needed until Django 4.2.1, so bring it back if we deploy something earlier than that to production.
This reverts commit 2cf2a3d.
Relying on Meta.ordering to order querysets involving GROUP BY queries is deprecated and will be dropped in Django 3.1.
Not sure why, but if I change the DeprecationWarning filter to "error", I get a SyntaxError from the \[ because it is an invalid escape sequence. Not sure why that change triggers it, but "\[" and "\\[" are the same, so this is a no-op.
rjsparks
approved these changes
May 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Django from 2.2 to 3.0, fixes all failing tests on my dev machine, and eliminates deprecation warnings.