Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatracker dark mode #3365

Closed
ietf-svn-bot opened this issue Jul 27, 2021 · 7 comments · Fixed by #5509 or #6010
Closed

Datatracker dark mode #3365

ietf-svn-bot opened this issue Jul 27, 2021 · 7 comments · Fixed by #5509 or #6010

Comments

@ietf-svn-bot
Copy link

type_enhancement | by [email protected]


Hi,

Too many IETF meetings in the middle of the night for me, perhaps, but if it were possible for the datatracker to have an automatic dark mode style sheet, based on system settings, that would be wonderful. :)

And yes, low priority, clearly.

Cheers,
Colin


Issue migrated from trac:3365 at 2022-03-04 09:09:44 +0000

@ietf-svn-bot
Copy link
Author

@[email protected] changed status from new to under_review

@larseggert larseggert self-assigned this Mar 2, 2023
@larseggert
Copy link
Collaborator

This needs [email protected].

larseggert added a commit to larseggert/datatracker that referenced this issue Apr 19, 2023
NGPixel pushed a commit to larseggert/datatracker that referenced this issue Apr 25, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue May 25, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue May 26, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue May 26, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue May 29, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue May 29, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue May 31, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue May 31, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue Jun 2, 2023
larseggert added a commit to larseggert/datatracker that referenced this issue Jun 2, 2023
@larseggert
Copy link
Collaborator

@rjsparks where are with merging feat/dark-mode?

@rjsparks
Copy link
Member

My understanding is that you were still working on it.
Does the branch contain all of your work so far or have I missed anything to merge into it?
We can send another request out for people to review it while at the meeting, and merge it after if no major issues are found.

Fwiw, I have protonopia complaints about it that spill over into things that I've just been tolerating, but are still not great in the light-mode to date. It's on my queue to write those up in a separate issue.

@larseggert
Copy link
Collaborator

I think I am done.

@rjsparks
Copy link
Member

I've merged main into the branch - there were conflicts - check that the merge commit does the correct thing please.
I'm building and deploying to dev - when that succeeds, I'll send a note to wgchairs and tools-discuss reminding people to try it and to send comments.

@larseggert
Copy link
Collaborator

Merge looks good. I'll have a PR with some minor fixes shortly.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.