Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Wal/index (Don't review) #1408

Closed
wants to merge 3 commits into from
Closed

WIP: Wal/index (Don't review) #1408

wants to merge 3 commits into from

Conversation

janardhan1993
Copy link
Contributor

@janardhan1993 janardhan1993 commented Sep 6, 2017

problem:

  1. we do a schema mutation, we update the schema but if we crash before index is rebuilt then on restart we don't rebuild because on replay we will see that it's already indexed so we don't do anything.
  2. Similarly for indexing on scalar values.

We store the current value of schema in wal on schema mutation, current pl(should be small for scalar values) for indexed predicates on mutation. On restart we can restore the schema and postings for scalar predicates to the value they should have been at snapshot using our wal.
So we can replay normally after restoring using our wal.

  1. reverse edges - no issues if we add the reverse edge always(we don't rely on hasmutated).

  2. count edges - WIP.


This change is Reviewable

@janardhan1993
Copy link
Contributor Author

Not needed now, will raise another PR for schema mutations.

@janardhan1993 janardhan1993 deleted the wal/index branch September 20, 2017 22:31
jarifibrahim pushed a commit that referenced this pull request Jul 11, 2020
This commit brings following new changes from badger
This commit also disable conflict detection in badger to save memory.

```
0dfb8b4 Changelog for v20.07.0 (#1411)
03ba278 Add missing changelog for v2.0.3 (#1410)
6001230 Revert "Compress/Encrypt Blocks in the background (#1227)" (#1409)
800305e Revert "Buffer pool for decompression (#1308)" (#1408)
63d9309 Revert "fix: Fix race condition in block.incRef (#1337)" (#1407)
e0d058c Revert "add assert to check integer overflow for table size (#1402)" (#1406)
d981f47 return error if the vlog writes exceeds more that 4GB. (#1400)
7f4e4b5 add assert to check integer overflow for table size (#1402)
8e896a7 Add a contribution guide (#1379)
b79aeef Avoid panic on multiple closer.Signal calls (#1401)
717b89c Enable cross-compiled 32bit tests on TravisCI (#1392)
09dfa66 Update ristretto to commit f66de99 (#1391)
509de73 Update head while replaying value log (#1372)
e013bfd Rework DB.DropPrefix (#1381)
3042e37 pre allocate cache key for the block cache and the bloom filter cache (#1371)
675efcd Increase default valueThreshold from 32B to 1KB (#1346)
158d927 Remove second initialization of writech in Open (#1382)
d37ce36 Tests: Use t.Parallel in TestIteratePrefix tests  (#1377)
3f4761d Force KeepL0InMemory to be true when InMemory is true (#1375)
dd332b0 Avoid panic in filltables() (#1365)
c45d966 Fix assert in background compression and encryption. (#1366)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants