Modify context to contain more information about query latency. #1402
Milestone
Comments
|
In general this would be a nice thing to make the query access other stuff through this parameter instead of using global variables in a bunch of different places. There is no way to get a grasp on what the surface between query evaluation code and data storage/clustering code is right now without having some global picture of the entire codebase. |
ghost
added
the
|
We'll use Open Census for request tracing. Tracked by #2257 . |
jarifibrahim
pushed a commit
that referenced
this issue
Jul 11, 2020
This commit brings following new changes from badger This commit also disable conflict detection in badger to save memory. ``` 0dfb8b4 Changelog for v20.07.0 (#1411) 03ba278 Add missing changelog for v2.0.3 (#1410) 6001230 Revert "Compress/Encrypt Blocks in the background (#1227)" (#1409) 800305e Revert "Buffer pool for decompression (#1308)" (#1408) 63d9309 Revert "fix: Fix race condition in block.incRef (#1337)" (#1407) e0d058c Revert "add assert to check integer overflow for table size (#1402)" (#1406) d981f47 return error if the vlog writes exceeds more that 4GB. (#1400) 7f4e4b5 add assert to check integer overflow for table size (#1402) 8e896a7 Add a contribution guide (#1379) b79aeef Avoid panic on multiple closer.Signal calls (#1401) 717b89c Enable cross-compiled 32bit tests on TravisCI (#1392) 09dfa66 Update ristretto to commit f66de99 (#1391) 509de73 Update head while replaying value log (#1372) e013bfd Rework DB.DropPrefix (#1381) 3042e37 pre allocate cache key for the block cache and the bloom filter cache (#1371) 675efcd Increase default valueThreshold from 32B to 1KB (#1346) 158d927 Remove second initialization of writech in Open (#1382) d37ce36 Tests: Use t.Parallel in TestIteratePrefix tests (#1377) 3f4761d Force KeepL0InMemory to be true when InMemory is true (#1375) dd332b0 Avoid panic in filltables() (#1365) c45d966 Fix assert in background compression and encryption. (#1366) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be good if we can know how many PL's were fetched from disk vs cache for a query.
We could maintain a wrapper struct around the
context.Contextthat we pass to all functions in the query path. This wrapper struct could also maintain other information (e.g. disk seeks, time-taken for processing different levels of the subgraph etc.) which can optionally be returned to the user. This would help us in determining why a particular query is taking time.The text was updated successfully, but these errors were encountered: