Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader/geojson #1375

Closed
wants to merge 6 commits into from
Closed

Loader/geojson #1375

wants to merge 6 commits into from

Conversation

pawanrawal
Copy link
Contributor

@pawanrawal pawanrawal commented Aug 30, 2017 •
edited by manishrjain
Loading

Resolves #1341

This change is Reviewable

@janardhan1993
Copy link
Contributor

:lgtm:

Reviewed 4 of 5 files at r1.
Review status: 4 of 5 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

client/client.go, line 427 at r1 (raw file):

}

func (e *Edge) SetValueGeoBytes(b []byte) error {

add a comment for godoc.

cmd/dgraphloader/main.go, line 309 at r1 (raw file):

	geoFilesList := fileList(*geoFiles)
	totalFiles := len(filesList) + len(geoFilesList)
	x.AssertTrue(totalFiles > 0)

It would be good if i can set just the schema with dgraphloader.

Comments from Reviewable

@manishrjain
Copy link
Contributor

:lgtm:

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

cmd/dgraphloader/main.go, line 52 at r1 (raw file):

	blockRate    = flag.Int("block", 0, "Block profiling rate")
	geoFiles     = flag.String("geo", "", "Location of geo files to load")
	geoPredicate = flag.String("geopred", "geometry",

default, make it loc.

Comments from Reviewable

@pawanrawal
Copy link
Contributor Author

This was merged.

@pawanrawal pawanrawal closed this Aug 31, 2017
@pawanrawal pawanrawal deleted the loader/geojson branch September 18, 2017 06:51
jarifibrahim pushed a commit that referenced this pull request Jul 11, 2020
Update badger to v20.0.7-rc1
07e288e 
This commit brings following new changes from badger
This commit also disable conflict detection in badger to save memory.

```
0dfb8b4 Changelog for v20.07.0 (#1411)
03ba278 Add missing changelog for v2.0.3 (#1410)
6001230 Revert "Compress/Encrypt Blocks in the background (#1227)" (#1409)
800305e Revert "Buffer pool for decompression (#1308)" (#1408)
63d9309 Revert "fix: Fix race condition in block.incRef (#1337)" (#1407)
e0d058c Revert "add assert to check integer overflow for table size (#1402)" (#1406)
d981f47 return error if the vlog writes exceeds more that 4GB. (#1400)
7f4e4b5 add assert to check integer overflow for table size (#1402)
8e896a7 Add a contribution guide (#1379)
b79aeef Avoid panic on multiple closer.Signal calls (#1401)
717b89c Enable cross-compiled 32bit tests on TravisCI (#1392)
09dfa66 Update ristretto to commit f66de99 (#1391)
509de73 Update head while replaying value log (#1372)
e013bfd Rework DB.DropPrefix (#1381)
3042e37 pre allocate cache key for the block cache and the bloom filter cache (#1371)
675efcd Increase default valueThreshold from 32B to 1KB (#1346)
158d927 Remove second initialization of writech in Open (#1382)
d37ce36 Tests: Use t.Parallel in TestIteratePrefix tests  (#1377)
3f4761d Force KeepL0InMemory to be true when InMemory is true (#1375)
dd332b0 Avoid panic in filltables() (#1365)
c45d966 Fix assert in background compression and encryption. (#1366)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janardhan1993 janardhan1993

@manishrjain manishrjain

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawanrawal @janardhan1993 @manishrjain