write hardstate after persisting the entries

[janardhan1993]

This change is 

[manishrjain]

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

raftwal/wal.go, line 132 at r1 (raw file):

	}

	if !raft.IsEmptyHardState(h) {

Create a PR for godoc of Raft as well, so it's clear that hard state should be written only after entries.

---

Comments from Reviewable

[janardhan1993]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

raftwal/wal.go, line 132 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Create a PR for godoc of Raft as well, so it's clear that hard state should be written only after entries.

Done.

---

Comments from Reviewable

[srh]

raftwal/wal.go, line 132 at r1 (raw file):

Previously, janardhan1993 (Janardhan Reddy) wrote…

Done.

Or at the same time.

---

Comments from Reviewable

[janardhan1993]

raftwal/wal.go, line 132 at r1 (raw file):

Previously, srh (Sam Hughes) wrote…

Or at the same time.

Badger doesn't support at the same time.

---

Comments from Reviewable

[manishrjain]

raftwal/wal.go, line 132 at r1 (raw file):

Previously, janardhan1993 (Janardhan Reddy) wrote…

Badger doesn't support at the same time.

Well, it does. You could do one batched write for both hard state and snapshot. Would be faster than doing one after another.

---

Comments from Reviewable

[srh]

raftwal/wal.go, line 132 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Well, it does. You could do one batched write for both hard state and snapshot. Would be faster than doing one after another.

Badger doesn't write those in one atomic write to the value log though, so the order still matters for Badger.

---

Comments from Reviewable