Make watermark not have WaitingFor #1377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. client/checkpoint.go, line 33 at r1 (raw file):
Because mark was being used as a WaitGroup I just put one right next to it. Comments from Reviewable |
|
Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. Comments from Reviewable |
|
Reviewed 4 of 4 files at r1. Comments from Reviewable |
|
In master as of f04b2df. |
jarifibrahim
pushed a commit
that referenced
this pull request
Jul 11, 2020
This commit brings following new changes from badger This commit also disable conflict detection in badger to save memory. ``` 0dfb8b4 Changelog for v20.07.0 (#1411) 03ba278 Add missing changelog for v2.0.3 (#1410) 6001230 Revert "Compress/Encrypt Blocks in the background (#1227)" (#1409) 800305e Revert "Buffer pool for decompression (#1308)" (#1408) 63d9309 Revert "fix: Fix race condition in block.incRef (#1337)" (#1407) e0d058c Revert "add assert to check integer overflow for table size (#1402)" (#1406) d981f47 return error if the vlog writes exceeds more that 4GB. (#1400) 7f4e4b5 add assert to check integer overflow for table size (#1402) 8e896a7 Add a contribution guide (#1379) b79aeef Avoid panic on multiple closer.Signal calls (#1401) 717b89c Enable cross-compiled 32bit tests on TravisCI (#1392) 09dfa66 Update ristretto to commit f66de99 (#1391) 509de73 Update head while replaying value log (#1372) e013bfd Rework DB.DropPrefix (#1381) 3042e37 pre allocate cache key for the block cache and the bloom filter cache (#1371) 675efcd Increase default valueThreshold from 32B to 1KB (#1346) 158d927 Remove second initialization of writech in Open (#1382) d37ce36 Tests: Use t.Parallel in TestIteratePrefix tests (#1377) 3f4761d Force KeepL0InMemory to be true when InMemory is true (#1375) dd332b0 Avoid panic in filltables() (#1365) c45d966 Fix assert in background compression and encryption. (#1366) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes WaitingFor() from WaterMark. Also the client code now uses a WaitGroup instead of using a WaterMark as one.
Connected to #1345
This change is